Skip to content

Fix stack overflow in ND orbital mechanics problems #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix stack overflow in ND orbital mechanics problems #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions benchmarks/NonStiffODE/enright_pryce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,16 +488,18 @@ const NC_PROBLEMS = [nc1prob, nc2prob, nc3prob, nc4prob] # nc5prob temporarily d
@variables y(t)[1:4]
y = collect(y)
@parameters ε
# Use intermediate variable to avoid complex symbolic expansion
# r_cubed = (x^2 + y^2)^(3/2) for the gravitational force law
r_squared = y[1]^2 + y[2]^2
r_cubed = r_squared * sqrt(r_squared)
nd1eqs = [D(y[1]) ~ y[3],
D(y[2]) ~ y[4],
D(y[3]) ~ (-y[1]) / r_cubed,
D(y[4]) ~ (-y[2]) / r_cubed]
@named nd1sys_raw = ODESystem(nd1eqs, t)
nd1sys = structural_simplify(nd1sys_raw)
nd1sys = complete(let
# Use intermediate variable to avoid complex symbolic expansion that causes stack overflow
# r_cubed = (x^2 + y^2)^(3/2) for the gravitational force law
r_squared = y[1]^2 + y[2]^2
r_cubed = r_squared * sqrt(r_squared)
nd1eqs = [D(y[1]) ~ y[3],
D(y[2]) ~ y[4],
D(y[3]) ~ (-y[1]) / r_cubed,
D(y[4]) ~ (-y[2]) / r_cubed
]
ODESystem(nd1eqs, t, name = :nd1)
end)

function make_ds(nd1sys, e)
y = collect(@nonamespace nd1sys.y)
Expand Down
Loading