Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks to nonlinear BVPs #766

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

michelle-zong
Copy link

No description provided.

@michelle-zong michelle-zong changed the title Mz/nonlinear bvp Add benchmarks to nonlinear BVPs Oct 12, 2023
---
title: Nonlinear BVP Benchmarks
author: Michelle Zong
TESTING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. This is not valid YAML Syntax

Comment on lines 51 to 53
wp_1 = WorkPrecisionSet(prob_1, abstols, reltols, setups; names = labels, print_names = true, appxsol = testsol_1,
dense=false, save_everystep=false,numruns=100,maxiters=10000000, timeseries_errors=false,verbose=false)
plot(wp_1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the maxiters and numruns for now. We can increase them once we have some results

@avik-pal
Copy link
Member

avik-pal commented Nov 5, 2023

@michelle-zong lets add Shooting and MultipleShooting in here as well. For the internal ODE solver corresponding to the tolerances see https://docs.sciml.ai/DiffEqDocs/dev/solvers/ode_solve/

"MIRK6";
"Shooting(Tsit5)";
"Shooting(Vern7)";
"MultipleShooting(Tsit5)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"MultipleShooting(Tsit5)",
"MultipleShooting(Tsit5)";

for (setup, label) in zip(setups, labels)
temp_sol = solve(prob, setup[:alg], abstol=1/10^8,reltol=1/10^8, dt=0.1)
test = TestSolution(temp_sol.t, temp_sol.u)
if SciMLBase.successful_retcode(test.retcode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this checking? It should be checking the recode fo the solution returned by solve

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now

@ErikQQY
Copy link
Member

ErikQQY commented Nov 15, 2023

Some rebase would make Buildkite work

@@ -1,4 +1,5 @@
[deps]
BVProblemLibrary = "ded0fc24-dfea-4565-b1d9-79c027d14d84"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in Project.toml and Manifest.toml are unnecessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BVProblemLibrary is needed, right? But yeah Weave should not be added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait this is duplicated. Erik is right, this needs to be removed

success_setups = []
success_labels = []
for (setup, label) in zip(setups, labels)
temp_sol = solve(prob, setup[:alg], abstol=1/10^8,reltol=1/10^8, dt=0.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed because prob here in this function is not defined

Fetch required packages.

```julia
using BoundaryValueDiffEq, OrdinaryDiffEq, DiffEqDevTools, BenchmarkTools, BVProblemLibrary, Weave, Plots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Weave from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants