Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

Rationale

I missed the opportunity to do this in time for 0.25.0, but I just tried this on my fork and saw no compilation error, so I'm proposing this change now.
I notice the wheels are not immediately tested, so I'm adding 3.14 to CI too (but I haven't tried that part on my fork yet, so, opening as a draft)

Implications

Removing CIBW_BUILD has the effect of letting cibuildwheel take the wheel (pun intended) and select target versions for you, where

  • the oldest Python version is either the oldest supported by cibuildwheel itself (currently 3.8) or the oldest version compatible with project.requires-python, as specified in pyproject.toml, whichever is newer.
  • the newest Python version selected depends on your pinned version of cibuildwheel, and usually include all ABI stable versions, so currently this goes up to 3.14

I'm however also adding a filter to CIBW_SKIP, otherwise cp314t wheels are also included by default, and I don't know what your plans are in this area.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2025

CLA assistant check
All committers have signed the CLA.

@neutrinoceros
Copy link
Contributor Author

Ah, of course pyproj doesn't trivially build from source so it's still a bit early to add 3.14 to CI.

@greglucas
Copy link
Contributor

Yeah, I figured that would be the case, so I didn't try too hard on the 3.14 aspect since we are still in rc's on many projects. Lets not wait another year to make a release though (note to self ;) ) so once our dependent projects release their wheels we should try to build and publish ours as well.

@neutrinoceros
Copy link
Contributor Author

I might forget about this PR when the time comes, so please don't hesitate to do what you please with it if it's any help in the future !

@QuLogic QuLogic added this to the Next Release milestone Aug 2, 2025
@djhoese
Copy link

djhoese commented Aug 6, 2025

FYI (as I'm reviewing what packages I depend on have 3.14 and free-threading enabled) my PR to pyproj just got merged to main. The release to PyPI isn't expected until September from what I was told and will include a bump in the PROJ version as well.

@neutrinoceros
Copy link
Contributor Author

Thanks ! I'll try to come back to this in a month or so and see where things are then !

@neutrinoceros
Copy link
Contributor Author

Looks like pyproj 3.7.2 came early with cp314 wheels, so let's try this one more time

@neutrinoceros neutrinoceros force-pushed the whl/cp314 branch 2 times, most recently from 7472598 to 2fd37fb Compare August 14, 2025 12:47
@neutrinoceros
Copy link
Contributor Author

the current blocker is now shapely

@djhoese
Copy link

djhoese commented Aug 14, 2025

Dang you're quick. I just released pyproj a couple hours ago.

@neutrinoceros
Copy link
Contributor Author

(I get RSS alerts for many PyPI package, including pyproj :))

@neutrinoceros
Copy link
Contributor Author

shapely 2.1.2 is out with cp314 wheels, let's try this again

@neutrinoceros
Copy link
Contributor Author

current blocker: fiona
this one is only an optional dependency though, so it should be possible to avoid it.

@neutrinoceros
Copy link
Contributor Author

Oh wait that's only for the regular CI part, let me just drop that real quick then

@neutrinoceros neutrinoceros marked this pull request as ready for review September 24, 2025 18:52
@neutrinoceros
Copy link
Contributor Author

wait, the wheel job didn't run. Can someone add the "Run cibuildwheel" label please ?

@QuLogic QuLogic added the CI: build wheels Run the release/wheel building on PR label Sep 24, 2025
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against freethreaded wheels, but I'm not sure if they work.

CIBW_BUILD: "cp310-* cp311-* cp312-* cp313-*"
# Skip 32 bit builds and musllinux due to lack of numpy wheels
CIBW_SKIP: "*-win32 *_i686 *-musllinux*"
CIBW_SKIP: "*-win32 *_i686 *-musllinux* cp3*t-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually, this does nothing, because the freethreaded one is missing the trailing *.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. Fixed

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Oct 13, 2025

Note to self: I want to upgrade cibw

@neutrinoceros
Copy link
Contributor Author

note to reviewers: upgrading cibw was needed to fix a bug on macos+intel+cp314 where cibuildwheel used to set an incorrect default value for MACOSX_DEPLOYMENT_TARGET

@neutrinoceros neutrinoceros requested a review from QuLogic October 13, 2025 10:29
@adamjstewart
Copy link

Anything I can do to help get this merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: build wheels Run the release/wheel building on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants