Implement Unit.change_calendar #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the test failures are due to my change.... |
@bjlittle and I are working on it |
|
@rcomer could you update your branch from |
|
Also this looks good to me and we're hoping to cut a release soon, so @larsbarring if you do have any thoughts, now is the time 😊 |
rcomer
force-pushed
the
replace_calendar
branch
from
07a4475 to
061f066
Compare
|
Thanks @trexfeathers, tests all passing now 🙂 |
trexfeathers
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Inspired by #185 (comment), introduce a method to replace a unit's calendar (if original and new calendar both represent the real world). I think this should be a step towards solving #185, and also may be useful for UM users if SciTools/iris#3561 is implemented.
@larsbarring I'd appreciate any feedback you may have on this.