pep518: purge legacy numpy workaround in setup.py #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cythonize = False | ||
| wmsg = "Cython unavailable, unable to cythonize cf-units extensions!" | ||
| warnings.warn(wmsg) | ||
| cythonize = None |
There was a problem hiding this comment.
Suggested change
| cythonize = None | |
| cythonize = False |
Previous was clearer in IMO
|
|
||
| if FLAG_COVERAGE in sys.argv or environ.get("CYTHON_COVERAGE", None): | ||
| if cythonize and cython_coverage_enabled: |
There was a problem hiding this comment.
Why has this changed from or to and?
pelson
reviewed
Feb 25, 2024
| from distutils.sysconfig import get_config_var | ||
| from os import environ | ||
| from pathlib import Path | ||
| from shutil import copy | ||
|
|
||
| # safe to import numpy here thanks to pep518 | ||
| import numpy as np | ||
| from setuptools import Command, Extension, setup | ||
|
|
||
| # Default to using cython, but use the .c files if it doesn't exist |
There was a problem hiding this comment.
Why would we want to have a build-time dependency on numpy, but an optional build-time dependency on Cython. Surely we can now move to a world where we unconditionally depend on Cython for building from source (and sdist)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR addresses some long outstanding technical debt, which thanks to pep518, we can finally tidy-up and simplify.
As a side-effect, developers can now easily build
cf-unitswithpython setup.py build_ext --inplace.