Fully support Python 3.12 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESadek-MO
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
THanks @trexfeathers. Looks good to me, and well commented, happy for this to go in!
|
Thanks @ESadek-MO! |
stephenworsley
added a commit
to rcomer/cf-units
that referenced
this pull request
Sep 24, 2024
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#425) Adopt cython3 (require >=3) (SciTools#460) Add repo-review (SciTools#456) Fully support Python 3.12 (SciTools#461) Bump peter-evans/create-pull-request from 6.0.4 to 7.0.5 (SciTools#459) Fix for bad git path in GHA macos instances. (SciTools#464) test macos wheels (SciTools#458) Bump pypa/cibuildwheel from 2.20.0 to 2.21.1 (SciTools#457) Fixes for CI wheels (SciTools#455) Dependabot check weekly. (SciTools#439) # Conflicts: # .pre-commit-config.yaml # cf_units/tests/test_coding_standards.py # pyproject.toml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
See https://github.com/SciTools/cf-units/pull/455/files#r1765037237 - #455 was missing a few changes.
I have also introduced a test that will catch things like this in future.
The commit history includes some narrative for the changes I have made.