DOCS: Enabled all pydocstyle (numpy) ruff rules with a list of specific exceptions. #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkknight
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5636 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
trexfeathers
reviewed
Feb 7, 2024
Comment on lines
128
to
+133
| ... warnings.filterwarnings("ignore", module="iris.coord_systems", lineno=449) | ||
| ... my_operation() | ||
| ... | ||
| iris/coord_systems.py:800: IrisDefaultingWarning: Discarding false_easting and false_northing that are not used by Cartopy. | ||
| iris/coord_systems.py:434: IrisUserWarning: Setting inverse_flattening does not affect other properties of the GeogCS object. To change other properties set them explicitly or create a new GeogCS instance. | ||
| warnings.warn(wmsg, category=iris.exceptions.IrisUserWarning) | ||
| iris/coord_systems.py:772: IrisDefaultingWarning: Discarding false_easting and false_northing that are not used by Cartopy. |
There was a problem hiding this comment.
Oops! Only just spotted this. The change should have instead been to update lineno= to correctly target the IrisUserWarning. #5736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Enabled all pydocstyle (numpy) ruff rules with a list of specific exceptions.
The temporary rules can be reviewed and either removed (then not ignored) or could be promoted to a permanent rule - which we want to minimize where possible.
Running ruff will still complete without warnings or errors for now.
$ ruff ../lib/irisConsult Iris pull request check list