- 
                Notifications
    You must be signed in to change notification settings 
- Fork 297
Release do-nothing script: correct handling of patch releases #6675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please see: SciTools/.github#191
| cls.get_github_user, | ||
| cls.get_release_type, | ||
| cls.analyse_remotes, | ||
| # cls.parse_tags, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
| for parts in remotes_split | ||
| ] | ||
|  | ||
| scitools_regex = re.compile(r"github\.com[:/]SciTools/iris\.git") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remotes do not have to end with .git. Would it still be unambiguous enough without?
🚀 Pull Request
Description
To-do
nothingfor testing the do-nothing scriptiris/tools/release_do_nothing.py
Lines 22 to 29 in bb248bc
series, which is meaningful to everyone while not being ambiguousConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: