feat(rfcs): Add RFC to describe the protocol for parsec-auth#9832
feat(rfcs): Add RFC to describe the protocol for parsec-auth#9832FirelightFlagboy wants to merge 1 commit into8482-rfc-parsec-authfrom
Conversation
8d84c6f to
7c15f87
Compare
AureliaDolo
left a comment
There was a problem hiding this comment.
It's cumbersome to read but it would be nice to have the same format as in others RFCs (like here) aka the json5 format
5ea50e6 to
f00ca9e
Compare
9d600ec to
1b78a5c
Compare
0a34bfc to
48ebbcb
Compare
48ec9e0 to
88f85c4
Compare
48ebbcb to
80b753b
Compare
| { | ||
| "cmd": "auth_medium_get", | ||
| "req": { | ||
| "id": "AuthMediumID" |
There was a problem hiding this comment.
How the client knows the auth medium ID that should be provided here ?
There was a problem hiding this comment.
I guess a new route is needed to "list" the registered auth mediums methods. That would seem consistent with the proposed routes to "add" and "remove" an auth method.
BTW, based on this comment, I would rename this route to be about the account manifest (and not the auth medium), so i suggest:
account_manifest_get(this route, to get the account manifest)auth_method_add(already described below)auth_method_remove(already described below)auth_method_list(route to be added below, allows to get the authmediummethod ID )
There was a problem hiding this comment.
auth_method_list could not be used to get the ID since it will be an authenticated route whose require AuthMediumID to generate the HMAC signature
There was a problem hiding this comment.
It was stated in the prior RFC that AuthMediumID is generated from the secret
|
|
||
| ### List available devices | ||
|
|
||
| To list the devices registered in the service, the client only needs to be authenticated: |
There was a problem hiding this comment.
This route is no longer useful since those data should be store in the account manifest
There was a problem hiding this comment.
All the encrypted devices would be stored in the account manifest? So is the client that directly stores that in the manifest?
If that's the case there is no need to "list" or "get" devices, but there is also no need to "upload" them either??
There was a problem hiding this comment.
We still need the list for the revoked_on field, current the manifest only store symmetric key to decrypt the devices.
Should we change that?
|
|
||
| ### List available devices | ||
|
|
||
| To list the devices registered in the service, the client only needs to be authenticated: |
There was a problem hiding this comment.
All the encrypted devices would be stored in the account manifest? So is the client that directly stores that in the manifest?
If that's the case there is no need to "list" or "get" devices, but there is also no need to "upload" them either??
63973d9 to
07a2a33
Compare
88f85c4 to
e7368fa
Compare
b19f93d to
9a57927
Compare
e7368fa to
fadbad2
Compare
9a57927 to
3ce8f93
Compare
8aefbd8 to
f68de51
Compare
3ce8f93 to
8b8aa70
Compare
aa05abb to
4401bea
Compare
8b8aa70 to
050fe3e
Compare
4401bea to
aaaffb8
Compare
050fe3e to
2a8ec56
Compare
Co-authored-by: Aurelia <56112063+AureliaDolo@users.noreply.github.com> Co-authored-by: Marcos Medrano <786907+mmmarcos@users.noreply.github.com> Co-authored-by: Emmanuel Leblond <emmanuel.leblond@gmail.com>
2a8ec56 to
fbdf700
Compare
aaaffb8 to
68b4ca2
Compare
|
Superseded by #10090 |
No description provided.