Skip to content

feat(rfcs): Add RFC to describe the protocol for parsec-auth#9832

Closed
FirelightFlagboy wants to merge 1 commit into8482-rfc-parsec-authfrom
rfc-parsec-auth-schema
Closed

feat(rfcs): Add RFC to describe the protocol for parsec-auth#9832
FirelightFlagboy wants to merge 1 commit into8482-rfc-parsec-authfrom
rfc-parsec-auth-schema

Conversation

@FirelightFlagboy
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cumbersome to read but it would be nice to have the same format as in others RFCs (like here) aka the json5 format

Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
@FirelightFlagboy FirelightFlagboy force-pushed the rfc-parsec-auth-schema branch from 9d600ec to 1b78a5c Compare March 5, 2025 15:58
@FirelightFlagboy FirelightFlagboy force-pushed the 8482-rfc-parsec-auth branch 3 times, most recently from 0a34bfc to 48ebbcb Compare March 7, 2025 13:56
@FirelightFlagboy FirelightFlagboy force-pushed the rfc-parsec-auth-schema branch 2 times, most recently from 48ec9e0 to 88f85c4 Compare March 10, 2025 12:59
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
{
"cmd": "auth_medium_get",
"req": {
"id": "AuthMediumID"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the client knows the auth medium ID that should be provided here ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a new route is needed to "list" the registered auth mediums methods. That would seem consistent with the proposed routes to "add" and "remove" an auth method.

BTW, based on this comment, I would rename this route to be about the account manifest (and not the auth medium), so i suggest:

  • account_manifest_get (this route, to get the account manifest)
  • auth_method_add (already described below)
  • auth_method_remove (already described below)
  • auth_method_list (route to be added below, allows to get the auth medium method ID )

Copy link
Copy Markdown
Contributor Author

@FirelightFlagboy FirelightFlagboy Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth_method_list could not be used to get the ID since it will be an authenticated route whose require AuthMediumID to generate the HMAC signature

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was stated in the prior RFC that AuthMediumID is generated from the secret

Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated

### List available devices

To list the devices registered in the service, the client only needs to be authenticated:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This route is no longer useful since those data should be store in the account manifest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the encrypted devices would be stored in the account manifest? So is the client that directly stores that in the manifest?

If that's the case there is no need to "list" or "get" devices, but there is also no need to "upload" them either??

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the list for the revoked_on field, current the manifest only store symmetric key to decrypt the devices.

Should we change that?

Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
@FirelightFlagboy FirelightFlagboy self-assigned this Mar 17, 2025
@mmmarcos mmmarcos linked an issue Mar 18, 2025 that may be closed by this pull request
@mmmarcos mmmarcos removed a link to an issue Mar 18, 2025
@mmmarcos mmmarcos linked an issue Mar 18, 2025 that may be closed by this pull request
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated

### List available devices

To list the devices registered in the service, the client only needs to be authenticated:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the encrypted devices would be stored in the account manifest? So is the client that directly stores that in the manifest?

If that's the case there is no need to "list" or "get" devices, but there is also no need to "upload" them either??

Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
@FirelightFlagboy FirelightFlagboy linked an issue Mar 19, 2025 that may be closed by this pull request
Comment thread docs/rfcs/1013-parsec-auth-scheme.md Outdated
@FirelightFlagboy FirelightFlagboy force-pushed the rfc-parsec-auth-schema branch 4 times, most recently from aa05abb to 4401bea Compare March 31, 2025 14:24
Co-authored-by: Aurelia <56112063+AureliaDolo@users.noreply.github.com>
Co-authored-by: Marcos Medrano <786907+mmmarcos@users.noreply.github.com>
Co-authored-by: Emmanuel Leblond <emmanuel.leblond@gmail.com>
@FirelightFlagboy
Copy link
Copy Markdown
Contributor Author

Superseded by #10090

@FirelightFlagboy FirelightFlagboy deleted the rfc-parsec-auth-schema branch April 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC Parsec Auth protocol

4 participants