-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lambdas and parens, multiple indents #347
base: master
Are you sure you want to change the base?
Conversation
@@ -255,18 +255,8 @@ _lambda_suite: _lambda_body | |||
| _standalone_lambda_stmt | |||
_lambda_body: _NL _INDENT _func_stmt+ _DEDENT | |||
_standalone_lambda_stmt: _simple_func_stmt | |||
// | annotation* compound_lambda_stmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opinionated, but I think fixing compound func stmt is the way to go and this works some of the time. could def revert this part tho
@Scony can you please take a look at this proposal? We too are running into the issue this PR is addressing and would love to see it merged. Thanks! |
I welcome you in the meanwhile to try installing this specific commit |
Got this in my queue, but it will take some time. |
Closes #346
Background: Thanks for making this tool. Lambda bugs were getting in the way in some cases, and I'd like to adopt it.
It seems INDENT and DEDENT were not emitted inside a lambda, other than one level deep.
I dove in and tried to fix it. The big test suite was a help as I thought I was done a few times.
I still noticed edge-cases with lambda, but mostly stuff like
which I looked at and had some ideas, like generating a virtual newline, but am leaving it here as I can work the codebase into shape now within the edge-cases