Skip to content

fix(shim): Don't throw if command was not found#6231

Open
o-l-a-v wants to merge 5 commits intoScoopInstaller:developfrom
o-l-a-v:fix-6206
Open

fix(shim): Don't throw if command was not found#6231
o-l-a-v wants to merge 5 commits intoScoopInstaller:developfrom
o-l-a-v:fix-6206

Conversation

@o-l-a-v
Copy link
Copy Markdown
Contributor

@o-l-a-v o-l-a-v commented Nov 20, 2024

Description

libexec\scoop-shim.ps1 function Get-ShimInfo should not throw if command was not found.

Motivation and Context

Closes #6206

How Has This Been Tested?

It was a small change, just adding -ErrorAction Ignore.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
    • I don't know how this can be tested.
  • I have added an entry in the CHANGELOG.

@o-l-a-v o-l-a-v changed the title fix (shim): Don't throw if command was not found fix(shim): Don't throw if command was not found Nov 26, 2024
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 8, 2025

Warning

Rate limit exceeded

@o-l-a-v has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 04b7ce7 and 3e3d1a6.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • libexec/scoop-shim.ps1 (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@o-l-a-v
Copy link
Copy Markdown
Contributor Author

o-l-a-v commented Sep 8, 2025

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 8, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant