Skip to content

Conversation

abgox
Copy link

@abgox abgox commented Aug 17, 2025

Description

Replace raw prints with functions for standardized output.

Motivation and Context

Closes #6450

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@abgox
Copy link
Author

abgox commented Aug 17, 2025

This change also improves compatibility with scoop-i18n.

@abgox
Copy link
Author

abgox commented Aug 19, 2025

  • @niheaven
  • There are some suggestions for modifying the output.
  • I think it can be modified in this PR as well.

https://github.com/ScoopInstaller/Scoop/blob/develop/lib/system.ps1#L110

# Write-Host "Adding $(friendly_path $_) to $(if ($Global) {'global'} else {'your'}) path."
Write-Host "Adding $(friendly_path $_) to $(if ($Global) {'system'} else {'user'}) environment variable $TargetEnvVar."

https://github.com/ScoopInstaller/Scoop/blob/develop/lib/system.ps1#L136

# Write-Host "Removing $(friendly_path $_) from $(if ($Global) {'global'} else {'your'}) path."
Write-Host "Adding $(friendly_path $_) to $(if ($Global) {'system'} else {'user'}) environment variable $TargetEnvVar."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants