Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User support: Sign over Base chainId #689

Closed
wants to merge 3 commits into from
Closed

User support: Sign over Base chainId #689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c8249d
Sign over Base chainId
garyghayrat Jul 10, 2024
93c8b8d
add type number
garyghayrat Jul 10, 2024
cf79534
Show correct message
garyghayrat Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions umbra-js/src/classes/Umbra.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,8 @@ export class Umbra {
const baseMessage = 'Sign this message to access your Umbra account.\n\nOnly sign this message for a trusted client!'; // prettier-ignore

// Append chain ID if not mainnet to mitigate replay attacks
const { chainId } = await this.provider.getNetwork();
const message = chainId === 1 ? baseMessage : `${baseMessage}\n\nChain ID: ${chainId}`;
const chainId = 8453; // Base chainId;
const message = `${baseMessage}\n\nChain ID: ${chainId}`;

// Get 65 byte signature from user using personal_sign
const userAddress = await signer.getAddress();
Expand Down
Loading