Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MData2 ingest needs to support number format and co-ordinate reference variants #10

Closed
10 tasks done
Scottapotamas opened this issue Oct 8, 2022 · 1 comment
Closed
10 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@Scottapotamas
Copy link
Owner

Scottapotamas commented Oct 8, 2022

MData2 packets have two-byte message ID's, where the last byte is used to describe the number format (#7) and coordinate reference (#5).

The ability to generate a correct MID exists for output as part of #9, but adding unit tests for parsing the resulting data fails as the MData2 parser assumes a table which maps to 0xabc0.

  • MData2 user-facing event types (XsensEventDataType_t) needs to support fixed-point and double typed data, and the array variations.
  • User-facing event union XsensEventData_t needs to support fixed-point and double types
  • xsens_mdata2_decode_field() needs to work out the data-type and coordinate frame from the last nibble of the inbound ID
  • Find the type in the table without the last nibble applied
  • Payload-into-union handling supports additional type possibilities
  • Refactor event handling structure to support co-ordinate reference metadata (enum for ENU, NED, NWU etc)
  • Existing test cases pass
  • Generate test packets with varied data types
  • Test case for each type (single, fixed-points, double) rotation matrix outputs
  • Write new test cases which include conversion of fixed-point data back to floating point
@Scottapotamas Scottapotamas added the enhancement New feature or request label Oct 8, 2022
@Scottapotamas Scottapotamas self-assigned this Oct 8, 2022
Scottapotamas added a commit that referenced this issue Oct 8, 2022
@Scottapotamas
Copy link
Owner Author

This issue is blocked until #11 is resolved.

Scottapotamas added a commit that referenced this issue Oct 12, 2022
Provides end-users with ability to check if a rotation was ENU, NED, NWU.
See #10
Scottapotamas added a commit that referenced this issue Oct 12, 2022
Scottapotamas added a commit that referenced this issue Oct 12, 2022
Provides end-users with ability to check if a rotation was ENU, NED, NWU.
See #10
Scottapotamas added a commit that referenced this issue Oct 18, 2022
Scottapotamas added a commit that referenced this issue Oct 18, 2022
Provides end-users with ability to check if a rotation was ENU, NED, NWU.
See #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant