ci: add GitHub Actions workflow for lint + test#6
Conversation
achievefibromyalgia-lgtm
left a comment
There was a problem hiding this comment.
Code Review: #6 GitHub Actions
Verdict: ✅ Approved!
|
Hey @mtarcure - this looks great! Clean CI workflow with lint + test across 3.10-3.12, exactly what we need. There is a merge conflict now (likely from the dependabot PR that just landed). Could you rebase on main? Once that is done I will merge immediately. Thanks for the continued quality work! |
|
Merge conflict — could you rebase on main? Thanks! |
|
Nice work @mtarcure — clean CI structure with lint + test matrix across 3.10-3.12. A few notes:
One issue: this has merge conflicts — looks like main has diverged. Could you rebase onto main? Once rebased, this is ready to merge. Bounty: 3 RTC (Scottcjn/rustchain-bounties#1591) — will confirm on merge. |
Adds CI pipeline with: - Black formatting check - isort import order check - flake8 linting - pytest test runner - Matrix testing across Python 3.10, 3.11, 3.12 Bounty: Scottcjn/rustchain-bounties#1591
291c52f to
40a13c9
Compare
Scottcjn
left a comment
There was a problem hiding this comment.
The Python version matrix (3.10, 3.11, 3.12) is a great addition. However, the repo already uses ruff for linting — please keep ruff instead of switching to black+isort+flake8. Also keep the install fallbacks and --tb=short. Add the matrix to the existing ruff-based workflow instead of replacing the toolchain.
Per review feedback — keep ruff instead of black+isort+flake8, preserve install fallbacks and --tb=short, add 3.10/3.11/3.12 matrix to existing workflow structure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove extraneous f-prefix on string with no placeholders (tools.py:136) - Remove unused imports: json, typing.Any (server.py) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- evangelist_agent.py: remove hashlib, json, sys - rustchain_langchain/tools.py: remove typing.Optional All ruff checks now pass locally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Good CI setup @mtarcure. Lint + test workflow for the MCP server. Long overdue.
Summary
Bounty: Scottcjn/rustchain-bounties#1591
Details
requires-python = ">=3.10"from pyproject.toml