Skip to content

ci: add GitHub Actions workflow for lint + test#6

Merged
Scottcjn merged 4 commits intoScottcjn:mainfrom
mtarcure:ci/add-github-actions
Mar 18, 2026
Merged

ci: add GitHub Actions workflow for lint + test#6
Scottcjn merged 4 commits intoScottcjn:mainfrom
mtarcure:ci/add-github-actions

Conversation

@mtarcure
Copy link
Copy Markdown
Contributor

Summary

  • Adds CI pipeline with lint (black, isort, flake8) and test (pytest) jobs
  • Matrix testing across Python 3.10, 3.11, 3.12
  • Runs on push to main and on pull requests

Bounty: Scottcjn/rustchain-bounties#1591

Details

  • Lint job: black formatting, isort imports, flake8 style checks
  • Test job: pytest with verbose output, runs after lint passes
  • Respects requires-python = ">=3.10" from pyproject.toml

Copy link
Copy Markdown

@achievefibromyalgia-lgtm achievefibromyalgia-lgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: #6 GitHub Actions

Verdict: ✅ Approved!

@Scottcjn
Copy link
Copy Markdown
Owner

Hey @mtarcure - this looks great! Clean CI workflow with lint + test across 3.10-3.12, exactly what we need.

There is a merge conflict now (likely from the dependabot PR that just landed). Could you rebase on main? Once that is done I will merge immediately.

Thanks for the continued quality work!

@Scottcjn
Copy link
Copy Markdown
Owner

Merge conflict — could you rebase on main? Thanks!

@Scottcjn
Copy link
Copy Markdown
Owner

Nice work @mtarcure — clean CI structure with lint + test matrix across 3.10-3.12.

A few notes:

  • ✅ Proper job ordering (test needs lint)
  • ✅ flake8 config with sensible line length
  • ✅ Uses pip install -e . for proper dependency resolution

One issue: this has merge conflicts — looks like main has diverged. Could you rebase onto main? Once rebased, this is ready to merge.

Bounty: 3 RTC (Scottcjn/rustchain-bounties#1591) — will confirm on merge.

Adds CI pipeline with:
- Black formatting check
- isort import order check
- flake8 linting
- pytest test runner
- Matrix testing across Python 3.10, 3.11, 3.12

Bounty: Scottcjn/rustchain-bounties#1591
@mtarcure mtarcure force-pushed the ci/add-github-actions branch from 291c52f to 40a13c9 Compare March 17, 2026 22:06
Copy link
Copy Markdown
Owner

@Scottcjn Scottcjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python version matrix (3.10, 3.11, 3.12) is a great addition. However, the repo already uses ruff for linting — please keep ruff instead of switching to black+isort+flake8. Also keep the install fallbacks and --tb=short. Add the matrix to the existing ruff-based workflow instead of replacing the toolchain.

Chrono and others added 3 commits March 17, 2026 16:38
Per review feedback — keep ruff instead of black+isort+flake8,
preserve install fallbacks and --tb=short, add 3.10/3.11/3.12
matrix to existing workflow structure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove extraneous f-prefix on string with no placeholders (tools.py:136)
- Remove unused imports: json, typing.Any (server.py)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- evangelist_agent.py: remove hashlib, json, sys
- rustchain_langchain/tools.py: remove typing.Optional

All ruff checks now pass locally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Scottcjn Scottcjn merged commit 6634c16 into Scottcjn:main Mar 18, 2026
6 checks passed
createkr pushed a commit to createkr/rustchain-mcp that referenced this pull request Mar 22, 2026
Good CI setup @mtarcure. Lint + test workflow for the MCP server. Long overdue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants