Fix undefined behavior

ScrapingAnt · Aug 24, 2021 · 8364a64 · 8364a64
1 parent 0a2a09f
commit 8364a64
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@scrapingant/scrapingant-client",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "ScrapingAnt API client for JavaScript",
   "main": "src/index.js",
   "keywords": [

diff --git a/src/index.js b/src/index.js
@@ -46,9 +46,11 @@ class ScrapingAntClient {
      *
      * @param {string} url
      * @param {object} [parameters]
+     * @param {string} [parameters.browser]
      * @param {string} [parameters.cookies]
      * @param {string} [parameters.js_snippet]
      * @param {string} [parameters.proxy_country]
+     * @param {string} [parameters.wait_for_selector]
      * @param {boolean} [parameters.return_text]
      */
     scrape(url, parameters) {

diff --git a/src/scraping_client.js b/src/scraping_client.js
@@ -37,7 +37,7 @@ class ScrapingClient {
             },
             data: {
                 url,
-                ...(parameters.browser && { browser: !!parameters.browser }),
+                ...(typeof parameters.browser !== 'undefined' && { browser: !!parameters.browser }),
                 ...(parameters.cookies && { cookies: parameters.cookies }),
                 ...(parameters.js_snippet && { js_snippet: base64encode(parameters.js_snippet) }),
                 ...(parameters.proxy_country && { proxy_country: parameters.proxy_country }),