ContentSearchResult #747
Open
ContentSearchResult #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcsaszar
requested changes
Feb 12, 2025
| 'reference', | ||
| { title: lang === 'de' ? 'Bild' : 'Image', to: 'Image' }, | ||
| ], | ||
| snippet: ['string', { title: lang === 'de' ? 'Schnipsel' : 'Snippet' }], |
There was a problem hiding this comment.
- Maybe more formal "Textausschnitt"?
| }, | ||
| title: async () => | ||
| (await load(currentLanguage)) === 'de' | ||
| ? 'Inhalts-Suchergebnis' |
There was a problem hiding this comment.
- FYI To make this more readable maybe it's sufficient to have just "search results" and (later on) "data search results". Alternatively maybe sth like "Suchtreffer (Content)"?
| connection: { | ||
| async index(params) { | ||
| if (Object.keys(params.filters()).length > 0) { | ||
| throw new Error('Filtering is not supported for CMS Search Results.') |
There was a problem hiding this comment.
- FYI strange capitalization in "Search Results".
|
|
||
| const objSearch = Obj.whereFullTextOf('*', 'matches', search) | ||
| .andNot('_objClass', 'equals', BLACKLIST_OBJ_CLASSES) | ||
| .and('_dataParam', 'equals', null) // Ignore data details pages |
There was a problem hiding this comment.
- Undocumented feature. Is there an issue for that? Maybe add a bit more about how/why/for how long this works to the comment? How about removing this magic and setting
excludeFromSearch: truefor these pages?
Comment on lines
+72
to
+74
| const snippet = | ||
| extractText(obj, { length: 300 }) || | ||
| ensureString(obj.get('metaDataDescription')) |
There was a problem hiding this comment.
- FMI how often/for which pages/objects is the fallback code path taken?
|
|
||
| function objToResult(obj: Obj) { | ||
| const imageReference = obj.get('image') | ||
| const image = isImage(imageReference) ? imageReference.id() : null |
There was a problem hiding this comment.
- FYI maybe use
imageIdhere for more clarity about the data in question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves search logic of https://github.com/Scrivito/scrivito-portal-app/blob/main/src/Widgets/SearchResultsWidget/SearchResultsWidgetComponent.tsx into a data class. Overall goal: Get rid of
SearchResultsWidgetand use data search primitives.Working copy to test it out: https://edit.scrivito.com/d0a154d76edf2a7bd991fc658e700a1d~https://contentsearchresult.scrivito-portal-app.pages.dev/en/search-results?q=Test&_scrivito_workspace_id=r228d708e9d6524d&_scrivito_display_mode=view
Please not that other PRs are still needed before the content can go live.