Added DataSearchCountWidget #752
Open
+111
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by party of SearchResultsWidget.
dcsaszar
requested changes
Feb 12, 2025
Comment on lines
+34
to
+50
| [ | ||
| 'headline0', | ||
| (headline) => | ||
| !headline && { | ||
| severity: 'warning', | ||
| message: 'The headline for 0 results should be set.', | ||
| }, | ||
| ], | ||
| [ | ||
| 'headline1', | ||
| (headline) => | ||
| !headline && { | ||
| severity: 'warning', | ||
| message: 'The headline for 1 result should be set.', | ||
| }, | ||
| ], | ||
| ], |
There was a problem hiding this comment.
- FYI as the component is happy and fully functioning without h0 and h1 we could drop these warnings.
There was a problem hiding this comment.
I think I remember how added the code originally 🙄: 1ec43ee#diff-bc72c026851dc07f2844efe663f800f856d2c52f02407caf602d951ad88fa353R42-R74
I think the validation is useful. Yes, you can leave the attribute empty, but then nothing is shown at all.
| import { EditorNote } from '../../Components/EditorNote' | ||
|
|
||
| provideComponent(DataSearchCountWidget, ({ widget }) => ( | ||
| <h1 className="h3 text-center"> |
There was a problem hiding this comment.
- Why is this an H1? Looks like a potential SEO pitfall.
<h3 className="text-center">? - FYI In general it's sad that we don't enable editors to show the result in any widget with any style they want. E.g., always-centered will not work for sites that use left-aligned headings. It would be great to have, e.g., a conditional widget that can operate on the result count, show different widgets depending on the value, and use a placeholder to show the value. Maybe a DataCountHeadlineWidget would be a sensible compromise.
There was a problem hiding this comment.
I added the options style, level and alignment. This hopefully helps to use it in more situations.
dcsaszar
requested changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by parts of SearchResultsWidget.