Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump patch external crates #100

Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore: bump patch external crates #100

merged 1 commit into from
Jul 4, 2023

Conversation

TroyKomodo
Copy link
Member

Proposed changes

Patches for fred: https://github.com/ScuffleTV/fred.rs
Patches for tracing: https://github.com/ScuffleTV/tracing

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

We will remove these patches when the upstreams fix their versions

@TroyKomodo TroyKomodo requested review from a team as code owners July 4, 2023 19:55
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build July 4, 2023 19:55 — with GitHub Actions Inactive
@TroyKomodo TroyKomodo requested a review from a team July 4, 2023 19:57
Copy link
Contributor

@chipsTM chipsTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TroyKomodo TroyKomodo temporarily deployed to lint-test-build July 4, 2023 20:33 — with GitHub Actions Inactive
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build July 4, 2023 20:44 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #100 (1dd88a4) into main (a494606) will decrease coverage by 0.06%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   74.25%   74.20%   -0.06%     
==========================================
  Files         216      216              
  Lines       15647    15628      -19     
==========================================
- Hits        11619    11596      -23     
- Misses       4028     4032       +4     
Impacted Files Coverage Δ
common/src/logging.rs 95.00% <92.30%> (+18.07%) ⬆️

... and 4 files with indirect coverage changes

@TroyKomodo TroyKomodo merged commit 1dd88a4 into main Jul 4, 2023
9 of 10 checks passed
@TroyKomodo TroyKomodo deleted the troy/cve branch July 4, 2023 21:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants