Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troy/router #207

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Troy/router #207

merged 2 commits into from
Mar 25, 2024

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Mar 20, 2024

Proposed changes

Extend the router to support express.js style middlewares. Where we get given a next function to call and then handle subsequent errors.

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Extend the router to support `express.js` style middlewares.
Where we get given a next function to call and then handle subsequent
errors.
@TroyKomodo TroyKomodo requested review from a team as code owners March 20, 2024 00:43
.middleware(middleware::auth::auth_middleware(global))
.scope("/v1", v1::routes(global))
.error_handler(utils::http::error_handler::<ApiError, _>)
// Our error handler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment intended to be here?

@lennartkloock lennartkloock merged commit 4493ebf into feature/website Mar 25, 2024
6 of 8 checks passed
@lennartkloock lennartkloock deleted the troy/router branch March 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants