feat: foundations #209
Open
feat: foundations #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/website #209 +/- ##
====================================================
- Coverage 46.72% 21.96% -24.77%
====================================================
Files 486 101 -385
Lines 30818 10683 -20135
====================================================
- Hits 14399 2346 -12053
+ Misses 16419 8337 -8082
|
Comment on lines
+4
to
+20
| # "platform/api", | ||
| "image-processor", | ||
| "image-processor/proto", | ||
| # "video/edge", | ||
| # "video/ingest", | ||
| # "video/transcoder", | ||
| # "video/lib/*", | ||
| # "video/api", | ||
| # "video/player", | ||
| # "video/player_types", | ||
| # "video/common", | ||
| # "video/cli", | ||
| # "binary-helper", | ||
| # "utils", | ||
| # "proto", | ||
| # "config", | ||
| # "config/derive", |
There was a problem hiding this comment.
due to changes the other libs dont build, and we havent fixed them so in order to use i commented them out
Converts the old dataloader model into a more generic batcher for any operations
TroyKomodo
force-pushed
the
foundations
branch
2 times, most recently
from
a5aefe2
to
e0eca0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.