Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transcoder Tests #93

Merged
merged 1 commit into from
May 31, 2023
Merged

Transcoder Tests #93

merged 1 commit into from
May 31, 2023

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented May 31, 2023 •
edited
Loading

Proposed changes

Adds very basic test for transcoder to validate that it works.

works on #86 point 2

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

-_-

@TroyKomodo TroyKomodo requested review from a team as code owners May 31, 2023 22:14
@TroyKomodo TroyKomodo changed the title Troy/transcoder tests Transcoder Tests May 31, 2023
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build May 31, 2023 22:15 — with GitHub Actions Inactive
@TroyKomodo TroyKomodo mentioned this pull request May 31, 2023
Closed
4 tasks
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build May 31, 2023 22:31 — with GitHub Actions Inactive
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build May 31, 2023 22:37 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #93 (c6c8d60) into main (c91422f) will increase coverage by 9.94%.
The diff coverage is 83.08%.

❗ Current head c6c8d60 differs from pull request most recent head f5c2914. Consider uploading reports for the commit f5c2914 to get more accurate results

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   63.93%   73.87%   +9.94%     
==========================================
  Files         209      209              
  Lines       15083    15180      +97     
==========================================
+ Hits         9643    11214    +1571     
+ Misses       5440     3966    -1474
Impacted Files Coverage Δ
video/transcoder/src/transcoder/mod.rs 82.35% <ø> (+82.35%) ⬆️
video/transcoder/src/transcoder/job/mod.rs 75.45% <75.00%> (+75.45%) ⬆️
video/ingest/src/ingest/connection.rs 67.83% <100.00%> (ø)
video/transcoder/src/transcoder/job/utils.rs 95.28% <100.00%> (+95.28%) ⬆️
video/transcoder/src/transcoder/job/variant/mod.rs 80.00% <100.00%> (+80.00%) ⬆️

... and 11 files with indirect coverage changes

@TroyKomodo TroyKomodo temporarily deployed to lint-test-build May 31, 2023 23:04 — with GitHub Actions Inactive
@TroyKomodo
feat: add transcoder tests
f5c2914 
This commit adds some very basic tests for the transcoder so that we can
confirm that the transcoder is working correctly.

partially works on #86 point 2
@TroyKomodo TroyKomodo temporarily deployed to lint-test-build May 31, 2023 23:05 — with GitHub Actions Inactive
4w3Official
4w3Official approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@4w3Official 4w3Official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TroyKomodo TroyKomodo merged commit f5c2914 into main May 31, 2023
@TroyKomodo TroyKomodo deleted the troy/transcoder-tests branch May 31, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4w3Official 4w3Official 4w3Official approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TroyKomodo @4w3Official