Skip to content

Conversation

@dfrankland
Copy link
Contributor

@dfrankland dfrankland commented Jan 22, 2026

PR Info

  • Dependencies:
  • Dependents:

New Features

Bug Fixes

  • fixes a compilation error when attempting to use the tracing-spans feature

Without this, the following compilation error is given:

   Compiling sea-orm v2.0.0-rc.28 (https://github.com/SeaQL/sea-orm?branch=master#b2c7d36f)
error[E0603]: enum import `DbOperation` is private
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:120:51
    |
120 |         let op = $crate::database::tracing_spans::DbOperation::from_sql(sql);
    |                                                   ^^^^^^^^^^^
    |                                                   |
    |                                                   private enum import
    |                                                   enum `DbOperation` is not publicly re-exported
    |
note: the enum import `DbOperation` is defined here...
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:105:5
    |
105 | use inner::*;
    |     ^^^^^^^^
note: ...and refers to the enum `DbOperation` which is defined here
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:33:5
    |
 33 |     pub(crate) enum DbOperation {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0603]: function import `db_system_name` is private
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:123:58
    |
123 |             db.system = $crate::database::tracing_spans::db_system_name($backend),
    |                                                          ^^^^^^^^^^^^^^
    |                                                          |
    |                                                          private function import
    |                                                          function `db_system_name` is not publicly re-exported
    |
note: the function import `db_system_name` is defined here...
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:105:5
    |
105 | use inner::*;
    |     ^^^^^^^^
note: ...and refers to the function `db_system_name` which is defined here
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:79:5
    |
 79 |     pub(crate) fn db_system_name(backend: DbBackend) -> &'static str {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0603]: function import `record_query_result` is private
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:154:46
    |
154 |             $crate::database::tracing_spans::record_query_result(&span, &result);
    |                                              ^^^^^^^^^^^^^^^^^^^
    |                                              |
    |                                              private function import
    |                                              function `record_query_result` is not publicly re-exported
    |
note: the function import `record_query_result` is defined here...
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:105:5
    |
105 | use inner::*;
    |     ^^^^^^^^
note: ...and refers to the function `record_query_result` which is defined here
   --> /Users/dylan/.cargo/git/checkouts/sea-orm-cde2287b59390390/b2c7d36/src/database/tracing_spans.rs:88:5
    |
 88 | /     pub(crate) fn record_query_result<T, E: std::fmt::Display>(
 89 | |         span: &tracing::Span,
 90 | |         result: &Result<T, E>,
 91 | |     ) {
...   |
101 | |     }
    | |_____^

For more information about this error, try `rustc --explain E0603`.
error: could not compile `sea-orm` (lib) due to 33 previous errors

Breaking Changes

Changes

Copy link

@pat-trunk-io pat-trunk-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops didn't mean to approve sorry

@dfrankland
Copy link
Contributor Author

Anything else that needs to get done for this to merge?

@Huliiiiii Huliiiiii merged commit f9c8d3f into SeaQL:master Jan 23, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants