This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Remove qu_factor_purchase_to_stock to maintain compatibility with API v4 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also confirmed this is working via the Home Assistant add-on that uses pygrocy here. |
SebRut
previously approved these changes
Aug 6, 2023
|
Fixed the formatting issue in 'task.py' that Black called out. Should pass now. |
SebRut
approved these changes
Aug 6, 2023
SebRut
previously approved these changes
Aug 7, 2023
|
Seems like Travis CI is broken for this project again, running pytest locally reports one failing test which should be an easy fix. |
|
Sorry about that - fixed and successfully ran pytests (all tests) locally |
SebRut
approved these changes
Aug 10, 2023
SebRut
added a commit
that referenced
this pull request
Aug 17, 2023
major release because qu_factor_purchase_to_stock was removed in #265 for compability with grocy v4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the changelog, v4.0.0 introduced a breaking change by removing
qu_factor_purchase_to_stockfrom the/products/{productId}endpoint. I'm proposing to remove the field and the associated validator to allow updated installations to be compatible.This does not add the new fields under the
/products/{productId}but fixes requests for Product data in updated installations.Checklist