update winit to 0.30 #152
update winit to 0.30 #152
Conversation
crates/demo/src/main.rs
Outdated
| Event::WindowEvent { event, .. } => { | ||
| if graphics.handle_event(&mut yak, &event, event_loop) { | ||
| return; |
There was a problem hiding this comment.
Can we preserve the original structure of the code here? The hope is that handle_event runs before your match block and helps filter out events. It should be able to accept the Event type just like before.
There was a problem hiding this comment.
see the comment on DeviceEvent
crates/yakui-winit/src/lib.rs
Outdated
| state: &mut yakui_core::Yakui, | ||
| event: &WinitEvent<T>, | ||
| ) -> bool { | ||
| pub fn handle_event(&mut self, state: &mut yakui_core::Yakui, event: &WindowEvent) -> bool { |
There was a problem hiding this comment.
We should preserve yakui's ability to handle winit's Event type to make it easier for users still using the old event loop style to integrate. Additionally, we probably do want to leave the door open to handle DeviceEvent without silently missing out on functionality.
A good way to solve this might be with an AsWinitEvent trait that we implement for Event, DeviceEvent, and WindowEvent. I'm not sure what the exact shape it should take is.
There was a problem hiding this comment.
we were more thinking of having a separate function for device events if and when it's needed
There was a problem hiding this comment.
@LPGhatguy Do you have any strong opinions on this? At least working with the newer changes to winit, they seem to want to rather separate the two events
No description provided.