Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vk::Format::R8G8B8A8_SRGB for srgb textures in vulkan #176

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Use vk::Format::R8G8B8A8_SRGB for srgb textures in vulkan #176

merged 1 commit into from
Jun 24, 2024

Conversation

HexyWitch
Copy link
Contributor

Fixes #174

Ralith
Ralith approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This smelled funny to me too, and I'd been meaning to investigate for a while. On review I think the original form can only possibly be correct if the shader is applying the EOTF itself, and it's not.

@LPGhatguy LPGhatguy merged commit 1cf49c0 into SecondHalfGames:main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@LPGhatguy LPGhatguy LPGhatguy approved these changes

@kanerogers kanerogers Awaiting requested review from kanerogers kanerogers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vulkan: Textures are not stored as sRGB
3 participants
@HexyWitch @Ralith @LPGhatguy