Various Flatpak/CMake fixes #675
Conversation
This updates all the CMake modules to use namespace targets, which have been supported since CMake 2.8 and bring fix a plethora of potential linking issues. Based on the documentation, these should work back until at least CMake 3.13 which is used by Debian Buster.
| install(DIRECTORY "${TSC_BINARY_DIR}/scriptdocs" | ||
| DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/doc/tsc | ||
| COMPONENT base) | ||
| endif() |
There was a problem hiding this comment.
Good catch. I didn't notice the problem -- thanks!
|
I'm unfamiliar with this new CMake target system, but I trust you know what you're doing. I've always used CMake's As for all the Is there a specific reason why Finally, two things for your information (I'll cater for these): First, I think tinyclipboard should be dropped in Ah, and the PR has conflicts with |
|
@refi64 Status of this? |
|
I uhhh forgot about it 😅 I'll see if I can look into it later this week. |
|
As the Flatpak topic came up in #706 again, might you look into getting this merged? |
The main commit is the switch to CMake namespace targets for loading external dependencies, which should fix all the weird build issues associated with the old way.