Skip to content

fix(ui): forward native section props in Card component and add unit test (#11620) #11646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jihadMo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): forward native section props in Card component and add unit test (#11620) #11646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/ui/src/Card.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import Card from './Card';

describe('Card UI Component', () => {
it('should export Card component accepting native HTML section props', () => {
expect(Card).toBeDefined();
expect(typeof Card).toBe('function');
});
});
19 changes: 14 additions & 5 deletions packages/ui/src/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
import React from "react";
import React from 'react';

export interface CardProps extends React.HTMLAttributes<HTMLElement> {
title?: string;
children: React.ReactNode;
}

export function Card({ title, children, className = '', style, ...rest }: CardProps) {
const defaultClassName = `border border-gray-200 dark:border-gray-800 rounded-lg p-4 bg-white dark:bg-gray-900 ${className}`.trim();

export function Card({ title, children }: { title: string; children: React.ReactNode }) {
return (
<section style={{ border: "1px solid #ddd", borderRadius: 8, padding: "1rem" }}>
<h3>{title}</h3>
<div>{children}</div>
<section className={defaultClassName} style={style} {...rest}>
{title && <h3 className="text-lg font-semibold mb-2">{title}</h3>}
{children}
</section>
);
}

export default Card;
Loading