feat: support multiple hosts and different public port

[thomasBousselin]

• I split the SED_PUBLIC_HOSTNAME by service because my services have different hostnames
• added a OFFERING_MANAGER_PUBLIC_API_PORT because my public port will be 443 (different to the external port from the container)
• Also renamed some variables to avoid confusion between dataplane and control plane

Edit: The configuration work on our side.
second commit contain the addition of https but i didn't bother making it configurable. (But it should be.)

[xamcost]

Hi @thomasBousselin ! Just dropping a review pointing towards some aspects I doubt about. I am not an expert of the connector so @juanrasantana and @vgonzalez7 should have a look and confirm.

[xamcost]

Two comments here:

• as you mentioned in your original post, it would be better to parametrize the protocol (http/https), so everyone gains in flexibility.
• I think this should be the following, considering that it is called DSP callback. @juanrasantana or @vgonzalez7 should have a look to confirm

Suggested change

	EDC_DSP_CALLBACK_ADDRESS: https://${CONN_DATA_PLANE_HOSTNAME}:${CONN_DATA_PLANE_PUBLIC_PORT}${CONN_DATA_PLANE_PUBLIC_PATH}
	EDC_DSP_CALLBACK_ADDRESS: https://${CONN_CONTROL_PLANE_HOSTNAME}:${CONN_CONTROL_PLANE_PORT}${CONN_CONTROL_PLANE_PATH}

[thomasBousselin]

Yes, the previous variable were indeed pointing to the control-plane. (easy to get mixed up with some of this names.)

[vgonzalez7]

What Maxime said is correct, the DSP is used by the control plane.

[xamcost]

Same comment here about the protocol

[thomasBousselin]

About the protocol it could be one variable total or one variable by service. Which one make more sense to you?

[xamcost]

Here as well, I find weird that the INTERNAL_CONNECTOR_ENDPOINT points towards the control plane, but the external one to the data plane. Moreover, is the offering manager even interacting with the data plane ? @juanrasantana and @vgonzalez7

[thomasBousselin]

yes, it is strange. But this one should be the equivalent to what the previous variables were doing.

[vgonzalez7]

What Thomas wrote is correct, this endpoint is used by the Offering Manager to fill the external endpoint when creating the offering (i.e. where the consumer will have to go to access the data), which is the data plane.
On the other hand, the internal endpoint is the one used for internal communication during the creation of the offerings, which is the control plane (this one was also correct).

[thomasBousselin]

After installind tcpdump and netstat in the docker. I have find the issue, the port defined are used inside the container so my control-plane and data-plane application are bind to 443.