Fix/kakao pay #153
+89
−21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,53 @@ | ||||||||
| package cc.backend.scheduler; | ||||||||
|
|
||||||||
| import cc.backend.ticket.entity.TempTicket; | ||||||||
| import cc.backend.ticket.repository.TempTicketRepository; | ||||||||
| import cc.backend.ticket.entity.enums.ReservationStatus; | ||||||||
| import cc.backend.kakaoPay.service.KakaoPayBusinessService; | ||||||||
| import java.time.LocalDateTime; | ||||||||
| import java.time.ZoneId; | ||||||||
| import java.util.List; | ||||||||
| import lombok.RequiredArgsConstructor; | ||||||||
| import lombok.extern.slf4j.Slf4j; | ||||||||
| import org.springframework.scheduling.annotation.Scheduled; | ||||||||
| import org.springframework.stereotype.Component; | ||||||||
|
|
||||||||
| @Component | ||||||||
| @RequiredArgsConstructor | ||||||||
| @Slf4j | ||||||||
| public class TempTicketExpireScheduler { | ||||||||
|
|
||||||||
| private final TempTicketRepository tempTicketRepository; | ||||||||
| private final KakaoPayBusinessService kakaoPayBusinessService; | ||||||||
|
|
||||||||
| // 1분마다 실행 | ||||||||
| @Scheduled(fixedDelay = 60000) | ||||||||
| public void expirePendingTickets() { | ||||||||
|
|
||||||||
| LocalDateTime nowKst = LocalDateTime.now(ZoneId.of("Asia/Seoul")); | ||||||||
| LocalDateTime expireTime = nowKst.minusMinutes(15); | ||||||||
|
Comment on lines
+27
to
+28
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Locate TempTicket entity
echo "=== Finding TempTicket entity ==="
fd -e java -path "*/entity/*" | xargs grep -l "class TempTicket" 2>/dev/null || rg -l "class TempTicket" --type=java
echo ""
echo "=== TempTicket entity - createdAt field definition ==="
rg "class TempTicket" -A 50 --type=java | head -100
echo ""
echo "=== Check for Hibernate/JDBC timezone configuration ==="
fd -e properties -o -e yml -o -e yaml | xargs grep -i "time.*zone\|jdbc.time_zone" 2>/dev/null || echo "No explicit timezone config found"
echo ""
echo "=== Check application.yml for timezone settings ==="
fd application.yml -o -path "*application*" -name "*.yml" -o -name "*.yaml" | head -5 | xargs cat 2>/dev/null | grep -i "timezone\|time-zone\|jackson\|jpa\|hibernate" || echo "Checking application.yml..."
echo ""
echo "=== Check for `@CreatedDate`, `@CreationTimestamp`, or `@Temporal` annotations ==="
rg "@CreatedDate|@CreationTimestamp|@Temporal|@Column.*columnDefinition" --type=java -B2 -A2
echo ""
echo "=== Check `@EnableScheduling` configuration ==="
rg "@EnableScheduling" --type=javaRepository: SeeATheater/CC_Backend Length of output: 14675 🏁 Script executed: cat -n src/main/java/cc/backend/ticket/entity/TempTicket.javaRepository: SeeATheater/CC_Backend Length of output: 2642 🏁 Script executed: cat -n src/main/java/cc/backend/domain/common/BaseEntity.javaRepository: SeeATheater/CC_Backend Length of output: 896 🏁 Script executed: find . -name "application*.yml" -o -name "application*.yaml" -o -name "application*.properties" | head -5 | xargs cat 2>/dev/null | head -100Repository: SeeATheater/CC_Backend Length of output: 2030 🏁 Script executed: rg "LocalDateTime.now()" --type=java -C2 | head -30Repository: SeeATheater/CC_Backend Length of output: 3183 Critical timezone mismatch: scheduler uses explicit Asia/Seoul zone while database stores
When the scheduler compares a KST-based Use the same timezone as the persistence layer: either 🐛 Proposed fix (if JVM default is UTC)- LocalDateTime nowKst = LocalDateTime.now(ZoneId.of("Asia/Seoul"));
- LocalDateTime expireTime = nowKst.minusMinutes(15);
+ LocalDateTime expireTime = LocalDateTime.now().minusMinutes(15);📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||
|
|
||||||||
| List<TempTicket> expiredTickets = | ||||||||
| tempTicketRepository.findExpiredPendingTickets(expireTime); | ||||||||
|
|
||||||||
| if (expiredTickets.isEmpty()) return; | ||||||||
|
|
||||||||
| log.info("TTL 만료 대상 {}개", expiredTickets.size()); | ||||||||
|
|
||||||||
| for (TempTicket tempTicket : expiredTickets) { | ||||||||
| try { | ||||||||
| if (tempTicket.getReservationStatus() != ReservationStatus.PENDING) | ||||||||
| continue; | ||||||||
|
|
||||||||
| kakaoPayBusinessService.stopPayment( | ||||||||
| String.valueOf(tempTicket.getId()) | ||||||||
| ); | ||||||||
|
|
||||||||
| log.info("tempTicket {} TTL 만료 처리 완료", tempTicket.getId()); | ||||||||
|
|
||||||||
| } catch (Exception e) { | ||||||||
| log.error("TTL expire 실패 tempTicketId={}", tempTicket.getId(), e); | ||||||||
| } | ||||||||
| } | ||||||||
| } | ||||||||
| } | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded production URL replaces previously externalized configuration — this breaks environment portability.
Replacing the
@Value-injected URL with a hardcoded"https://seeatheater.site"means local development, staging, and other environments all redirect to production. The commented-out localhost line on line 24 confirms this is being toggled manually, which is error-prone and could easily leak into production with the wrong value.Re-externalize this to
application.yml(or environment variable), as it was before:🐛 Proposed fix
In
application.yml, add:In the controller:
🤖 Prompt for AI Agents