-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build: Building in Docker Container + update action versions #673
Conversation
66d8872
to
ede4d9f
Compare
Awesome! Thanks for getting this working again! Two notes:
|
Regardless of any of the discussion above: ACK. |
|
@kdmukai I would be also fine with SeedSigner/seedsigner-os#83 first and then updating this PR to use docker-compose |
@dbast no, I think the fewer blockers/dependencies here, the better. My priority is just to get this repo back to green and finally sprint our way to the v0.8.5 release. Plenty of time for further improvements after that release! So I reiterate my ACK for this PR and hope for a speedy merge! |
ACK |
Description
This fixes the build workflow by:
actions/upload-artifact@v4
each artifact uploaded must have a distinct name.related for better build error propagation SeedSigner/seedsigner-os#84
Note: Ignore the occational failing CI / test workflows on this PR; those are addressed in #671.
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.