Deposit contract + actions #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| ); | ||
|
|
||
| // Compute deposit data root (`DepositData` hash tree root) | ||
| bytes32 consensus_pubkey_hash = sha256(abi.encodePacked(consensus_pubkey, bytes16(0))); |
There was a problem hiding this comment.
Bug: SSZ Hashing Mismatch Breaks Deposit Verification
The consensus_pubkey (48 bytes padded to 64) is hashed as a single 64-byte value, but SSZ requires splitting into two 32-byte chunks that are hashed separately before combining. This inconsistency with the consensus_signature handling (which correctly splits chunks) will cause incorrect hash tree root computation and deposit verification failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce Eth2 DepositContract, add viem ABI/actions and client integration, plus end-to-end tests, and bump package versions.
DepositContractincontracts/src/DepositContract.solimplementingdeposit,get_deposit_root,get_deposit_count, and ERC-165 support.contracts/foundry.toml(via_ir = true).seismic-viem):depositContractAbiand actions insrc/abis/depositContract.tsandsrc/actions/depositContract.ts(read:getDepositRoot,getDepositCount; write:deposit; exportDEPOSIT_CONTRACT_ADDRESS).createShieldedPublicClient/createShieldedWalletClientto include deposit contract public/wallet actions and export address viasrc/index.ts.1.0.51.seismic-viem-tests):tests/contract/depositContract.tswith ABI/bytecode fixtures; wire into test runner and exports.contracts/test/ShieldedDelegationAccount.t.sol.seismic-reactpeer toseismic-viem >=1.0.51and version to1.0.51.Written by Cursor Bugbot for commit b2e30c5. This will update automatically on new commits. Configure here.