Get forecasts for an asset-id instead of passing location

[Ahmad-Wahid]

Changes:

• User can now pass --asset-id to get forecasts for all the registered sensor(s) of the given asset. This is an alternative of --location.
• Now using GenericAsset(Type) instead of Asset(Type).

[nhoening]

Just a better suggestion for the exception message.

[nhoening]

I believe we should also add the --asset-id parameter to the owm register-weather-sensor CLI command.

Then both CLI commands let you specify the exact weather station (by ID) that should be used.

[Ahmad-Wahid]

Is this asset-id required for sensor registration?

By both commands, you mean asset-id and (lat and long that are required for sensor registration)?

[nhoening]

Is this asset-id required for sensor registration?

To identify the weather station bi ID, not by location.

By both commands, you mean asset-id and (lat and long that are required for sensor registration)?

I mean the two CLI commands we have in this plugin, sensor registration and forecast retrieval. We worked already on the latter.

[Ahmad-Wahid]

Okay, understood. Now if I pass asset-id to registor a weather sensor, the weather station should be created before this step and it requires latitude and longitude.

[nhoening]

Looks good, just a few small suggestions.

[nhoening]

Thanks

[nhoening]

@Ahmad-Wahid we still have a failing test (probably because we now are not raising where we used to before:

def test_get_weather_forecasts_no_close_sensors(
        app, db, monkeypatch, run_as_cli, add_weather_sensors_fresh_db
    ):
        """
        Looking for a location too far away from existing weather stations means we fail.
        """
        weather_station = add_weather_sensors_fresh_db["wind"].generic_asset
    
        monkeypatch.setitem(app.config, "OPENWEATHERMAP_API_KEY", "dummy")
        monkeypatch.setattr(owm, "call_openweatherapi", mock_owm_response)
    
        runner = app.test_cli_runner()
        result = runner.invoke(
            collect_weather_data,
            ["--location", f"{weather_station.latitude-5},{weather_station.longitude}"],
        )
        print(result.output)
>       assert "Reported task get-openweathermap-forecasts status as False" in result.output
E       AssertionError: assert 'Reported task get-openweathermap-forecasts status as False' in '[FLEXMEASURES-OWM] Only one location: 28.4843866,126.0.\n[FLEXMEASURES-OWM] Getting weather forecasts:\n[FLEXMEASURES...ask get-openweathermap-forecasts ran fine.\n[FLEXMEASURES] Reported task get-openweathermap-forecasts status as True\n'
E        +  where '[FLEXMEASURES-OWM] Only one location: 28.4843866,126.0.\n[FLEXMEASURES-OWM] Getting weather forecasts:\n[FLEXMEASURES...ask get-openweathermap-forecasts ran fine.\n[FLEXMEASURES] Reported task get-openweathermap-forecasts status as True\n' = <Result okay>.output

Please adjust the test, then this PR can be merged.