You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the format of the RustExtension key to use a string instead of a dictionary
The dictionary key for the RustExtension is incorrectly formatted as a dictionary itself. It should be a string representing the name of the extension.
Why: The suggestion corrects a potential bug by changing the dictionary key to a string, which is the correct format for the RustExtension.
10
Best practice
Specify a precise Python version range in requires-python to avoid including future, potentially unsupported versions
The requires-python field should specify a range that includes only the supported versions, not using the tilde approximation which might unintentionally include future, unsupported Python versions.
Why: This suggestion improves the precision of the Python version range, ensuring compatibility and preventing future unsupported versions from being included.
8
Adjust the version constraint for urllib3 to allow for minor updates within the same major version
The dependency version for urllib3 should allow for minor updates within a major version, rather than restricting to a minor version range.
Why: Allowing minor updates within the same major version for urllib3 can improve compatibility and security by including minor updates and patches.
7
Enhancement
Enable namespace packaging if the packages are part of a namespace
The namespace field in the [tool.setuptools.packages.find] section should be set to true if the packages are intended to be part of a namespace package.
Why: This suggestion is contextually accurate but should be verified if the packages are indeed part of a namespace. If not, this change could introduce issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
setup.py
topyproject.toml
Motivation and Context
pyproject.toml
is one stop solution which eliminates whole bunch of configuration files.Types of changes
Checklist
PR Type
Enhancement
Description
setup.py
topyproject.toml
.setup.py
.pyproject.toml
.pyproject.toml
.pyproject.toml
.Changes walkthrough 📝
setup.py
Removed project metadata from `setup.py`.
py/setup.py
URLs, classifiers, packages, and dependencies.
configuration.
pyproject.toml
Added project metadata to `pyproject.toml`.
py/pyproject.toml
readme, Python requirements, classifiers, and dependencies.
documentation, and source code.