Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet][rb][java][js][py] Automated Browser Version Update #14375

Closed
wants to merge 1 commit into from

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Aug 11, 2024

This is an automated pull request to update pinned browsers and drivers

Merge after verify the new browser versions properly passing the tests and no bugs need to be filed

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Maintainability
Use a common variable for the URL prefix to simplify future updates and improve code readability

Consider using a variable for the common URL prefix
"https://ftp.mozilla.org/pub/firefox/releases/" to make future updates easier and
the code cleaner.

common/repositories.bzl [14-75]

-url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/linux-x86_64/en-US/firefox-129.0.tar.bz2"
-url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/mac/en-US/Firefox%20129.0.dmg"
-url = "https://ftp.mozilla.org/pub/firefox/releases/130.0b3/linux-x86_64/en-US/firefox-130.0b3.tar.bz2"
-url = "https://ftp.mozilla.org/pub/firefox/releases/130.0b3/mac/en-US/Firefox%20130.0b3.dmg"
+FIREFOX_RELEASE_URL = "https://ftp.mozilla.org/pub/firefox/releases/"
+url = FIREFOX_RELEASE_URL + "129.0/linux-x86_64/en-US/firefox-129.0.tar.bz2"
+url = FIREFOX_RELEASE_URL + "129.0/mac/en-US/Firefox%20129.0.dmg"
+url = FIREFOX_RELEASE_URL + "130.0b3/linux-x86_64/en-US/firefox-130.0b3.tar.bz2"
+url = FIREFOX_RELEASE_URL + "130.0b3/mac/en-US/Firefox%20130.0b3.dmg"
 
  • Apply this suggestion
Suggestion importance[1-10]: 8

Why: This suggestion improves maintainability by reducing redundancy and making future updates easier. It is a significant improvement for code readability and maintainability.

8
Best practice
Use variables for platform and language in URLs for flexibility and maintainability

To avoid hardcoding the platform and language in the URL, use variables that can be
set globally or passed as parameters to the function.

common/repositories.bzl [14]

-url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/linux-x86_64/en-US/firefox-129.0.tar.bz2"
+PLATFORM = "linux-x86_64"
+LANGUAGE = "en-US"
+url = f"https://ftp.mozilla.org/pub/firefox/releases/129.0/{PLATFORM}/{LANGUAGE}/firefox-129.0.tar.bz2"
 
  • Apply this suggestion
Suggestion importance[1-10]: 8

Why: This suggestion enhances flexibility and maintainability by avoiding hardcoding, making the code more adaptable to changes in platform or language.

8
Possible issue
Ensure consistent URL encoding to prevent parsing errors

Ensure that the URL encoding for spaces as '%20' is consistently applied or handled
automatically to avoid potential issues with URL parsing.

common/repositories.bzl [36]

-url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/mac/en-US/Firefox%20129.0.dmg"
+url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/mac/en-US/Firefox 129.0.dmg".replace(" ", "%20")
 
  • Apply this suggestion
Suggestion importance[1-10]: 7

Why: Ensuring consistent URL encoding can prevent potential parsing issues, which is important for reliability. However, the improvement is relatively minor and specific to one URL.

7
Enhancement
Add a verification step for URL integrity to prevent runtime failures

Consider verifying the integrity of the URLs by adding a step to check the
availability or correctness of the URLs during the build process or via automated
tests.

common/repositories.bzl [14]

 url = "https://ftp.mozilla.org/pub/firefox/releases/129.0/linux-x86_64/en-US/firefox-129.0.tar.bz2"
+# Add verification step here
 
  • Apply this suggestion
Suggestion importance[1-10]: 6

Why: Adding a verification step for URL integrity is a good enhancement for reliability, but the suggestion is somewhat vague and lacks specific implementation details.

6

Copy link

codiumai-pr-agent-pro bot commented Aug 11, 2024

CI Failure Feedback 🧐

(Checks updated until commit b6f0252)

Action: Ruby / Local Tests (firefox, macos) / Local Tests (firefox, macos)

Failed stage: Run Bazel [❌]

Failure summary:

The action failed due to the following reasons:

  • The analysis of the target //rb/spec/integration/selenium/webdriver:fedcm-firefox failed because the
    module extension pin_browsers_extension from //common:repositories.bzl does not generate the
    repository linux_edge, which is required.
  • As a result of the above failure, the build was aborted.
  • No test targets were found, yet testing was requested, leading to the failure of the process.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  macOS
    ...
    
    614:  �[32mAnalyzing:�[0m 28 targets (31 packages loaded, 17 targets configured)
    615:  �[32m[0 / 1]�[0m [Prepa] BazelWorkspaceStatusAction stable-status.txt
    616:  �[32mAnalyzing:�[0m 28 targets (146 packages loaded, 19 targets configured)
    617:  �[32m[1 / 1]�[0m checking cached actions
    618:  �[32mAnalyzing:�[0m 28 targets (181 packages loaded, 40 targets configured)
    619:  �[32m[1 / 1]�[0m checking cached actions
    620:  �[32mAnalyzing:�[0m 28 targets (193 packages loaded, 1470 targets configured)
    621:  �[32m[1 / 1]�[0m checking cached actions
    622:  �[31m�[1mERROR: �[0mAnalysis of target '//rb/spec/integration/selenium/webdriver:fedcm-firefox' failed; build aborted: module extension "pin_browsers_extension" from "//common:repositories.bzl" does not generate repository "linux_edge", yet it is imported as "linux_edge" in the usage at /Users/runner/work/selenium/selenium/MODULE.bazel:349:39
    623:  �[32mINFO: �[0mElapsed time: 19.518s, Critical Path: 1.18s
    624:  �[32mINFO: �[0m1 process: 1 internal.
    625:  �[31m�[1mERROR: �[0mBuild did NOT complete successfully
    626:  �[31m�[1mFAILED:�[0m 
    627:  �[31m�[1mERROR: �[0mNo test targets were found, yet testing was requested
    628:  �[0m
    629:  ##[error]Process completed with exit code 1.
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @selenium-ci selenium-ci force-pushed the pinned-browser-updates branch 6 times, most recently from dd8c873 to 53714c2 Compare August 18, 2024 00:39
    @diemol diemol closed this Aug 19, 2024
    @diemol diemol deleted the pinned-browser-updates branch August 19, 2024 07:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants