-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Selenium Manager errors when browser-path is wrong (#13352) #14381
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
CI Failure Feedback 🧐(Checks updated until commit 3b93e38)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
d4ff06e
to
b876e22
Compare
f32e0ea
to
f3444e7
Compare
User description
Description
This PR makes SM to error when the specified browser path does not exists. Example:
Motivation and Context
Requested in #13352.
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
fallback_driver_from_cache
field toManagerConfig
struct and initialized it in the constructor.fallback_driver_from_cache
configuration.main.rs
to use the fallback driver from cache if the browser path is invalid.Changes walkthrough 📝
config.rs
Add fallback driver from cache configuration to ManagerConfig
rust/src/config.rs
fallback_driver_from_cache
field toManagerConfig
struct.fallback_driver_from_cache
inManagerConfig
constructor.lib.rs
Handle invalid browser path and manage fallback driver
rust/src/lib.rs
fallback_driver_from_cache
.main.rs
Update error handling to use fallback driver from cache
rust/src/main.rs
fallback_driver_from_cache
.browser_tests.rs
Add test for invalid browser path handling
rust/tests/browser_tests.rs