-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[ci] Use pagination in mirror workflow to get all Selenium releases #16605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||||
User description
🔗 Related Issues
The latest IEDriverServer was done a long time ago (Selenium 4.14), and so, it is currently excluded from the default GitHub API response used for the mirror workflow (due to result pagination). As a result, the support of IEDriverServer in Selenium Manager was started to fail:
It is currently failing in CI:
https://github.com/SeleniumHQ/selenium/actions/runs/19414639574/job/55541217140
💥 What does this PR do?
This PR changes the mirror workflow to get all pages in the GitHub API responses. This way, even old releases (e.g., Selenium 4.14) are kept in the mirror file, and Selenium Manager should be able to find IEDriverServer, as usual.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Bug fix
Description
Implements pagination in mirror workflow to fetch all GitHub releases
Fixes IEDriverServer availability by retrieving old Selenium releases
Adds error handling and improved shell script robustness
Processes paginated API responses into consolidated mirror file
Diagram Walkthrough
File Walkthrough
mirror-selenium-releases.yml
Add pagination logic to GitHub releases API calls.github/workflows/mirror-selenium-releases.yml
(100 per page)
set -euo pipefailfor shell script robustnessjq-s 'add'pagination progress