Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java/src/org/openqa/selenium/support/ui/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ java_library(
visibility = [
"//java/src/org/openqa/selenium/support:__subpackages__",
],
deps = [
artifact("org.jspecify:jspecify"),
],
)

java_library(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.openqa.selenium.support.ui;

import org.jspecify.annotations.NullMarked;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mk868 please add Nullmarked annotation and import to package-info.java on ui package level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iampopovich Thanks, NullMarked has been moved


/**
* Represents any abstraction of something that can be loaded. This may be an entire web page, or
* simply a component within that page (such as a login box or menu) or even a service. The expected
Expand All @@ -32,6 +34,7 @@
*
* @param <T> The type to be returned (normally the subclass' type)
*/
@NullMarked
public abstract class LoadableComponent<T extends LoadableComponent<T>> {
/**
* Ensure that the component is currently loaded.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.time.Clock;
import java.time.Duration;
import java.time.Instant;
import org.jspecify.annotations.NullMarked;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a reminder to remove import here after you add package-info.java to ui package


/**
* A {@link LoadableComponent} which might not have finished loading when load() returns. After a
Expand All @@ -32,6 +33,7 @@
*
* @param <T> The type to be returned (normally the subclass' type)
*/
@NullMarked
public abstract class SlowLoadableComponent<T extends LoadableComponent<T>>
extends LoadableComponent<T> {

Expand Down
Loading