Skip to content

[rb] should not need long client timeout in tests #16847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 3 commits into from
Jan 7, 2026
+4 −6
Merged

[rb] should not need long client timeout in tests #16847

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a999521
[rb] should not need long client timeout in tests
titusfortner Jan 5, 2026
88b0368
grid needs a longer timeout
titusfortner Jan 5, 2026
f131fd9
just make everything 30
titusfortner Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,13 @@ def root
@root ||= Pathname.new('../../../../../../../').realpath(__FILE__)
end

def create_driver!(listener: nil, **, &block)
def create_driver!(listener: nil, http_client: nil, **, &block)
check_for_previous_error
http_client ||= Remote::Http::Default.new(read_timeout: 30)

method = :"#{driver}_driver"
instance = if private_methods.include?(method)
send(method, listener: listener, options: build_options(**))
else
WebDriver::Driver.for(driver, listener: listener, options: build_options(**))
end
opts = {options: build_options(**), listener: listener, http_client: http_client}
instance = private_methods.include?(method) ? send(method, **opts) : WebDriver::Driver.for(driver, **opts)
@create_driver_error_count -= 1 unless @create_driver_error_count.zero?
if block
begin
Expand Down