Skip to content

[dotnet] Correlate low level http requests/responses and log failures #17074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 3 commits into from
Feb 10, 2026
Merged

[dotnet] Correlate low level http requests/responses and log failures #17074

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2be1901
[dotnet] Correlate low level http requests/responses and log failures
nvborisenko Feb 10, 2026
a1d478d
Generate correlation only if tracing enabled
nvborisenko Feb 10, 2026
7071b83
Use marker in exception trace log
nvborisenko Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,10 +435,13 @@ public DiagnosticsHttpHandler(HttpMessageHandler messageHandler, ILogger logger)
/// <returns>The http response message content.</returns>
protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
string requestId = request.GetHashCode().ToString("x8");

Comment thread
nvborisenko marked this conversation as resolved.
Outdated
if (_logger.IsEnabled(LogEventLevel.Trace))
{
Comment thread
nvborisenko marked this conversation as resolved.
Outdated
StringBuilder requestLogMessageBuilder = new();
requestLogMessageBuilder.AppendFormat(">> {0} {1}",
requestLogMessageBuilder.AppendFormat(">> [{0}] {1} {2}",
requestId,
request.Method,
request.RequestUri?.ToString() ?? "null");

Expand All @@ -455,13 +458,29 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
_logger.Trace(requestLogMessageBuilder.ToString());
}

var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
HttpResponseMessage response;

try
{
response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
}
catch (Exception ex)
{
if (_logger.IsEnabled(LogEventLevel.Trace))
{
_logger.Trace($"<< [{requestId}] {ex}");
}

throw;
}

if (_logger.IsEnabled(LogEventLevel.Trace))
{
StringBuilder responseLogMessageBuilder = new();

responseLogMessageBuilder.AppendFormat("<< {0} {1}", (int)response.StatusCode, response.ReasonPhrase);
responseLogMessageBuilder.AppendFormat("<< [{0}] {1} {2}",
requestId,
(int)response.StatusCode,
response.ReasonPhrase);
Comment thread
nvborisenko marked this conversation as resolved.
Outdated
Comment thread
nvborisenko marked this conversation as resolved.

if (!response.IsSuccessStatusCode && response.Content != null)
{
Expand Down
Loading