Skip to content

fix(update_cdp): update file paths for ChromeDriver configuration - #17319

Merged
diemol merged 1 commit into
trunkfrom
update-dotnet-path
Apr 8, 2026
Merged

diemol merged 1 commit into
trunkfrom
update-dotnet-path

Conversation

@diemol

@diemol diemol commented Apr 8, 2026

Copy link
Copy Markdown
Member

Fixing this path to do a release.

Copilot AI review requested due to automatic review settings April 8, 2026 17:03
@qodo-code-review

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update .NET ChromeDriver configuration file paths

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Update .NET test file paths for ChromeDriver configuration
• Correct directory structure references in update_cdp script
• Align paths with current .NET project layout

Grey Divider

File Changes

1. scripts/update_cdp.py 🐞 Bug fix +2/-2

Fix .NET test file paths in CDP update script

• Updated StableChannelChromeDriver.cs path from dotnet/test/common/CustomDriverConfigs/ to
 dotnet/test/webdriver/Infrastructure/DriverConfigs/
• Updated DevTools directory path from dotnet/test/common/DevTools to
 dotnet/test/webdriver/DevTools
• Corrects file references used during ChromeDriver CDP version updates

scripts/update_cdp.py


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)
🐞\ ⚙ Maintainability (1)

Grey Divider


Remediation recommended

1. README path mismatch 🐞 ⚙
Description
dotnet/src/webdriver/DevTools/README.md still instructs updating //dotnet/test/common/DevTools, but
update_cdp.py now updates //dotnet/test/webdriver/DevTools. Following the README will fail
(directory no longer exists) and can cause future CDP updates to miss required test updates.
Code

scripts/update_cdp.py[R185-186]

+    files = [root_dir / "dotnet/test/webdriver/Infrastructure/DriverConfigs/StableChannelChromeDriver.cs"]
+    dir_path = root_dir / "dotnet/test/webdriver/DevTools"
Evidence
update_dotnet() was changed to target dotnet/test/webdriver/DevTools, while the README still
documents dotnet/test/common/DevTools (which is no longer present), so the documented procedure is
inconsistent with the current repo layout and automation.

scripts/update_cdp.py[174-190]
dotnet/src/webdriver/DevTools/README.md[40-42]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`dotnet/src/webdriver/DevTools/README.md` still references the old test path `//dotnet/test/common/DevTools/`, but the repo and `scripts/update_cdp.py` now use `//dotnet/test/webdriver/DevTools/`.

### Issue Context
This mismatch will cause developers to follow incorrect instructions during future CDP updates.

### Fix Focus Areas
- dotnet/src/webdriver/DevTools/README.md[40-42]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Apr 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the .NET test file paths used by scripts/update_cdp.py when bumping CDP/Chrome milestone references, aligning the update script with the current dotnet/test/webdriver/... test layout so releases can be cut successfully.

Changes:

  • Update the StableChannelChromeDriver.cs path to the current .NET test location.
  • Update the DevTools test directory path to dotnet/test/webdriver/DevTools.

Comment thread scripts/update_cdp.py
@diemol
diemol merged commit 2fed1c0 into trunk Apr 8, 2026
27 checks passed
@diemol
diemol deleted the update-dotnet-path branch April 8, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants