Skip to content

[py] fix linting and mypy to properly exclude generated bidi files #17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgoldberg merged 2 commits into from
May 10, 2026
Merged

[py] fix linting and mypy to properly exclude generated bidi files #17433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34f179f
[py] fix linting and mypy to properly exclude generated bidi files
cgoldberg May 10, 2026
300c8e2
Change glob to regex
cgoldberg May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions py/docs/source/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ webdriver.common

selenium.webdriver.common.action_chains
selenium.webdriver.common.alert
selenium.webdriver.common.api_request_context
selenium.webdriver.common.by
selenium.webdriver.common.desired_capabilities
selenium.webdriver.common.driver_finder
Expand Down Expand Up @@ -91,6 +92,8 @@ webdriver.common.bidi
.. autosummary::
:toctree: selenium_webdriver_common_bidi

selenium.webdriver.common.bidi._event_manager
selenium.webdriver.common.bidi.bluetooth
selenium.webdriver.common.bidi.browser
selenium.webdriver.common.bidi.browsing_context
selenium.webdriver.common.bidi.cdp
Expand All @@ -103,7 +106,9 @@ webdriver.common.bidi
selenium.webdriver.common.bidi.permissions
selenium.webdriver.common.bidi.script
selenium.webdriver.common.bidi.session
selenium.webdriver.common.bidi.speculation
selenium.webdriver.common.bidi.storage
selenium.webdriver.common.bidi.user_agent_client_hints
selenium.webdriver.common.bidi.webextension

webdriver.common.fedcm
Expand Down
2 changes: 1 addition & 1 deletion py/private/ruff_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from python.runfiles import Runfiles

ALL_DIRS = ["py", "scripts", "common", "dotnet", "java", "javascript", "rb"]
EXCLUDES = ["**/node_modules/**", "**/.bundle/**", "**/devtools/**"]
EXCLUDES = ["**/node_modules/**", "**/.bundle/**", "**/bidi/**", "**/devtools/**"]


def run_check(ruff, exclude_args, dirs, extra_args):
Expand Down
2 changes: 1 addition & 1 deletion py/private/ruff_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from python.runfiles import Runfiles

ALL_DIRS = ["py", "scripts", "common", "dotnet", "java", "javascript", "rb"]
EXCLUDES = ["**/node_modules/**", "**/.bundle/**", "**/devtools/**"]
EXCLUDES = ["**/node_modules/**", "**/.bundle/**", "**/bidi/**", "**/devtools/**"]


def run_format(ruff, exclude_args, dirs, extra_args):
Expand Down
8 changes: 7 additions & 1 deletion py/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ testpaths = ["test"]

# mypy global options
[tool.mypy]
exclude = "selenium/webdriver/common/devtools"
# The aim in future is we would be able to turn (most) of these flags on
# warn about per-module sections in the config file that do not match any files processed.
warn_unused_configs = true
Expand Down Expand Up @@ -137,6 +136,13 @@ warn_return_any = false
# Shows a warning when encountering any code inferred to be unreachable after performing type analysis.
warn_unreachable = false

[[tool.mypy.overrides]]
module = [
"selenium.webdriver.common.devtools.*",
"selenium.webdriver.common.bidi.*",
]
ignore_errors = true
Comment thread
qodo-code-review[bot] marked this conversation as resolved.

[tool.ruff]
extend-exclude = [
"selenium/webdriver/common/devtools/",
Expand Down
Loading