fix(scan): show validator 'Registered' timestamp on detail page#74
Merged
Merged
Conversation
Operator noticed the validators page has no "how long has this validator been online" indicator. The chain's legacy /validators endpoint exposes `registered_at` (unix seconds) but the merge in fetchValidators only pulled name + blocks_produced from it. Now carries `registered_at` through to the merged row and renders a "Registered" InfoRow on the detail page under Status. List page stays clean — detail-page surface is the standard explorer pattern (Etherscan's "Created" / Solana Beach's "Started" both live on the detail page, not the list). Field already existed on ValidatorData; no chain-side change needed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds validator registration date visibility by extending the validator detail page. The API layer now preserves the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator noticed scan v1's validators page has no "how long this validator has been online" indicator. The chain's legacy
/validatorsendpoint exposesregistered_at(unix seconds) butfetchValidatorswas only pullingname+blocks_producedfrom it. This carriesregistered_atthrough to the merged row and renders aRegisteredInfoRow on the detail page underStatus.Field already exists on
ValidatorData— no chain-side change needed.Why detail page only
List page stays clean. Showing "registered" on the detail page is the standard explorer pattern (Etherscan's "Created", Solana Beach's "Started" both live there, not on list rows).
Verification
After this PR: clicking through to a validator detail page shows e.g. "Registered: Apr 23, 2026" between Status and Stake.
Test plan
scan.sentrixchain.com/en/validators/0x4cad...and confirm "Registered" row renderspnpm --filter=@sentriscloud/scan typecheckgreen (verified locally)Summary by CodeRabbit
Release Notes