build(deps): bump tonic from 0.12.3 to 0.13.1#24
Conversation
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Around line 25-26: The project uses tonic = "0.13" but tonic-web-wasm-client
remains at "0.6", which pulls tonic ^0.12 and causes multiple tonic versions;
update the tonic-web-wasm-client dependency in Cargo.toml to "0.7" so it aligns
with tonic 0.13 (change the tonic-web-wasm-client version string), then run
cargo update (or regenerate Cargo.lock) to ensure the lockfile resolves to a
single tonic 0.13.x version and restore type compatibility for WASM gRPC paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7bd64d76-f4b1-4f0f-9ba2-4adfeea15522
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock,!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
| tonic = { version = "0.13", default-features = false, features = ["prost", "codegen"] } | ||
| tonic-web-wasm-client = "0.6" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Cargo.toml dependency check =="
rg -n '^(tonic|tonic-web-wasm-client)\s*=' Cargo.toml || true
if [[ -f Cargo.lock ]]; then
echo
echo "== tonic versions present in Cargo.lock =="
python - <<'PY'
import re
from pathlib import Path
text = Path("Cargo.lock").read_text(encoding="utf-8")
versions = []
for block in text.split('[[package]]'):
n = re.search(r'\nname = "([^"]+)"', block)
v = re.search(r'\nversion = "([^"]+)"', block)
if n and v and n.group(1) == "tonic":
versions.append(v.group(1))
uniq = sorted(set(versions))
print("tonic versions:", uniq if uniq else "(none)")
if len(uniq) > 1:
print("⚠ Multiple tonic versions detected; verify tonic-web-wasm-client compatibility.")
PY
else
echo "Cargo.lock not found. Generate/update lockfile locally, then re-run this check."
fiRepository: Sentriscloud/sentrix-explorer-v2
Length of output: 395
🌐 Web query:
tonic-web-wasm-client 0.7 tonic dependency requirements crates.io
💡 Result:
The tonic-web-wasm-client crate version 0.7 (specifically 0.7.1, released 2025-05-28) depends on tonic ^0.13[1][2]. Tonic is listed as a non-default dependency ("no" under Default Features), meaning it is required but not enabled by default features of tonic-web-wasm-client[1][2]. To use it with Tonic gRPC clients in WASM/browser environments, disable tonics transport feature (compile without tonics transport feature flag) and use tonic-web-wasm-client as the transport layer[2][3][4]. Full dependencies for 0.7.1 include: base64 ^0.22, byteorder ^1, bytes ^1, futures-util ^0.3, http ^1, http-body ^1, http-body-util ^0.1, httparse ^1, js-sys ^0.3, pin-project ^1, thiserror ^2, tonic ^0.13, tower-service ^0.3, wasm-bindgen ^0.2, wasm-bindgen-futures ^0.4, wasm-streams ^0.4, web-sys ^0.3[1][2]. The crate is WASM-only; build with --target wasm32-unknown-unknown[2].
Citations:
- 1: https://crates.io/crates/tonic-web-wasm-client/0.7.1
- 2: https://docs.rs/crate/tonic-web-wasm-client/0.7.1
- 3: https://github.com/devashishdxt/tonic-web-wasm-client
- 4: https://docs.rs/tonic-web-wasm-client/latest/tonic_web_wasm_client/
Upgrade tonic-web-wasm-client to 0.7 to align with tonic 0.13
Line 25 upgrades tonic to 0.13, but line 26 keeps tonic-web-wasm-client at 0.6, which depends on tonic ^0.12. This causes multiple tonic versions in the lock file (0.12.3 and 0.13.1), breaking type compatibility in WASM gRPC paths.
Fix
-tonic-web-wasm-client = "0.6"
+tonic-web-wasm-client = "0.7"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| tonic = { version = "0.13", default-features = false, features = ["prost", "codegen"] } | |
| tonic-web-wasm-client = "0.6" | |
| tonic = { version = "0.13", default-features = false, features = ["prost", "codegen"] } | |
| tonic-web-wasm-client = "0.7" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Cargo.toml` around lines 25 - 26, The project uses tonic = "0.13" but
tonic-web-wasm-client remains at "0.6", which pulls tonic ^0.12 and causes
multiple tonic versions; update the tonic-web-wasm-client dependency in
Cargo.toml to "0.7" so it aligns with tonic 0.13 (change the
tonic-web-wasm-client version string), then run cargo update (or regenerate
Cargo.lock) to ensure the lockfile resolves to a single tonic 0.13.x version and
restore type compatibility for WASM gRPC paths.
Bumps [tonic](https://github.com/hyperium/tonic) from 0.12.3 to 0.13.1. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](hyperium/tonic@v0.12.3...v0.13.1) --- updated-dependencies: - dependency-name: tonic dependency-version: 0.13.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d542d32 to
f592071
Compare
|
Looks like tonic is up-to-date now, so this is no longer needed. |
Bumps tonic from 0.12.3 to 0.13.1.
Changelog
Sourced from tonic's changelog.
Commits
b303caachore: Preparev0.13.1releaseee6775cRevert "[spr] initial version (#2264)" (#2265)fd60c04[spr] initial version (#2264)aa27260feat: expose creation of HealthService and HealthReporter (#2251)9669ce4chore(tonic-bench): Fix failing bench (#2207)67e2ef9fix: tls config overwrite in endpoint (#2252)eeac1d3chore: Fix interop test certs (#2262)1c139f3chore: Addflake.nix(#2261)97001f3chore: Use inline format argument (#2260)cb6c67fchore: Use symbolic link for license file (#2241)Summary by CodeRabbit