feat: bump tonic 0.12→0.14 + tonic-web-wasm-client 0.6→0.9 + prost 0.13→0.14#25
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR upgrades the gRPC-Web and protocol buffer code generation stack across build and runtime dependencies. The build system migrates from Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
… 0.6→0.7 tonic 0.14 split prost integration into separate `tonic-prost` (runtime) + `tonic-prost-build` (codegen) crates. tonic itself no longer exposes the `prost` feature. build.rs: tonic_build::configure() → tonic_prost_build::configure() compile_protos_with_config() → compile_with_config() (renamed in 0.14) Cargo.toml: runtime: drop tonic["prost"] feature, add tonic-prost dep build-dep: tonic-build → tonic-prost-build, prost-build 0.13 → 0.14 tonic-web-wasm-client 0.6 → 0.9 (matches tonic 0.14) gloo-net 0.6 → 0.7 The gloo-net bump is required to align the WASM bundle on a single wasm-streams version. tonic-web-wasm-client 0.9 needs wasm-streams 0.5; gloo-net 0.6 still pulled wasm-streams 0.4. Rust-lld then hard-failed with hundreds of duplicate-symbol errors on `__wbindgen_describe_*` exports because both versions register the same wasm-bindgen functions. gloo-net 0.7 dropped to wasm-streams 0.5 — single version, link clean. Verification: cargo leptos build --release (full mainnet bundle, WASM + SSR) cargo check --target wasm32 (browser path) Supersedes #19 (gloo-net), supersedes the earlier #15/#23 already closed.
3f33a98 to
c8abcc7
Compare
Cluster A3 of the major-bump audit (explorer V2 side — completes Cluster A).
Changes
API migrations
tonic_build::configure()→tonic_prost_build::configure().compile_protos_with_config()→.compile_with_config()(renamed in 0.14)tonicfeatureprostremoved (provided by separatetonic-prostcrate)Verification
cargo check --target wasm32-unknown-unknown— clean (browser bundle)cargo check --features ssr— clean (axum server build)Both code paths the explorer ships (CSR/hydrate in browser, SSR axum binary on the host) compile.
Supersedes #15, #23. Coordinates with sdk-rs#15 and sentrix-grpc-wasm#12 (both already opened in this cluster).
Summary by CodeRabbit