LibCrypto: Remove FIXMEs regarding possible optimizations in SHA{1,256}

These do not bring any noticeable (>0.5%) performance improvements.
SerenityOS · Jul 12, 2024 · 9bbadf7 · 9bbadf7
1 parent 16a2511
commit 9bbadf7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/Userland/Libraries/LibCrypto/Hash/SHA1.cpp b/Userland/Libraries/LibCrypto/Hash/SHA1.cpp
@@ -106,10 +106,6 @@ template<>
     auto sha_rnds4 = []<int i> [[SHA_TARGET]] (u32x4 a, u32x4 b) { return bit_cast<u32x4>(__builtin_ia32_sha1rnds4(bit_cast<i32x4>(a), bit_cast<i32x4>(b), i)); };
 
     auto group = [&]<int i_group> [[SHA_TARGET]] () {
-        //" // FIXME: Trailing quote to fix syntax highlighting, somethings off with function like attributes and templated lambdas in VsCode
-        // FIXME: Test if unrolling the loop is worth it
-        //          GCC: #pragma GCC unroll(5)
-        //        Clang: #pragma unroll
         for (size_t i_pack = 0; i_pack != 5; ++i_pack) {
             size_t i_msg = i_group * 5 + i_pack;
             if (i_msg < 4) {
@@ -155,8 +151,6 @@ decltype(SHA1::transform_dispatched) SHA1::transform_dispatched = [] {
             return &SHA1::transform_impl<CPUFeatures::X86_SHA | CPUFeatures::X86_SSE42>;
     }
 
-    // FIXME: Investigate if more target clones (avx) make sense
-
     return &SHA1::transform_impl<CPUFeatures::None>;
 }();
 

diff --git a/Userland/Libraries/LibCrypto/Hash/SHA2.cpp b/Userland/Libraries/LibCrypto/Hash/SHA2.cpp
@@ -135,8 +135,6 @@ decltype(SHA256::transform_dispatched) SHA256::transform_dispatched = [] {
             return &SHA256::transform_impl<CPUFeatures::X86_SHA | CPUFeatures::X86_SSE42>;
     }
 
-    // FIXME: Investigate if more target clones (avx) make sense
-
     return &SHA256::transform_impl<CPUFeatures::None>;
 }();