LibWeb: Specify input box width when parent does not

[Arben-Sear]

Text input boxes inside a parent with no defined width, such as the following, appear too short in Ladybird.

<div style = "float:left">
    <input style = "width:auto">
</div>

See #23915, which this fixes.

The fix was two parts: remove some hacky code from HTMLInputElement::adjust_computed_style() that set the width of any input box container with <... width:auto> and instead use set_natural_width() and set_natural_height() in the Layout::BlockContainer constructor.

NOTES/Pending issues

• Despite setting natural height to 1lh, some text boxes (such as the one on the ladybird home screen) are now too short. I believe natural width and height might ignore padding/margins/borders, but I'm not sure.
• Apologies, but this probably won't pass the code submission policies -- this is my first ever PR.
  • EDIT: all pending changes done -- we could use feedback on the failing checks, see previous note

[BuggieBot]

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

[awesomekling]

These changes are spread across three separate commits even though they're just iterating on the same places again and again. I think it would be better to just squash them all into one commit that gets to the end state immediately. :)

[awesomekling]

This can be:

if (dom_node()->is_html_input_element()) {

[Arben-Sear]

I did something similar elsewhere, but it took the form if (foo.dom_node() && foo.dom_node()->is_html_input_element()). Is this okay?

[Arben-Sear]

@awesomekling I performed the changes as you requested. There's still the issue with input box height:

It appears as though using natural_height doesn't account for borders/padding. Any recommendations?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!