Utilities/wc: Seek the input file(s) if only -c is passed #24499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
supercomputer7
force-pushed
the
wc-bytes-only-seek
branch
2 times, most recently
from
99e9120
to
cb86853
Compare
supercomputer7
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
timschumi
requested changes
Jun 29, 2024
supercomputer7
force-pushed
the
wc-bytes-only-seek
branch
from
cb86853
to
8365e47
Compare
If the user only wants to get the byte count of a set of files, then for each file we can simply seek it to get the byte count instead of iterating over all the bytes.
supercomputer7
force-pushed
the
wc-bytes-only-seek
branch
from
8365e47
to
ab65f4b
Compare
timschumi
approved these changes
Jun 29, 2024
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user only wants to get the byte count of a set of files, then for each file we can simply seek it to get the byte count instead of iterating over all the bytes.
Revives #21961. The original PR had a bug in which
-cwouldn't be able to handle standard input stream, but now I added a condition to handleESPIPEerror as well.