Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Update the Ladybird repo notice and remove it from the README #24663

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

circl-lastname
Copy link
Contributor

@circl-lastname circl-lastname commented Jul 4, 2024

As it has been a month since the migration, I believe it is safe to remove the warning and specify the state of the SerenityOS version of the Ladybird browser.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 4, 2024
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change to README.md.

I left a bikesheddy comment about the other paragraph.

Documentation/BuildInstructionsLadybird.md Outdated Show resolved Hide resolved
@nico nico added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Jul 4, 2024
@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author labels Jul 6, 2024
@nico nico merged commit 00029e0 into SerenityOS:master Jul 6, 2024
11 checks passed
@nico
Copy link
Contributor

nico commented Jul 6, 2024

Thanks!

@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 6, 2024
@circl-lastname circl-lastname deleted the note_update branch July 7, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants