LibPDF: Use draw_rect() to show debug clipping rects
#24677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the path rasterizer here is much slower than simply drawing four lines. This also more accurately shows the (real) clip as the bounding box is truncated to an int before adding it as a clip rect. Fixes SerenityOS#23056
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Jul 12, 2024
| m_painter.clear_clip_rect(); | ||
| if (m_rendering_preferences.show_clipping_paths) { | ||
| m_painter.stroke_path(rect_path(bounding_box), Color::Black, 1); | ||
| m_painter.draw_rect(bounding_box, Color::Black); |
There was a problem hiding this comment.
Eventually we'll want to clip against the full path and then probably draw it here, I'm guessing. But this is a clear improvement for now, thanks!
This also more accurately shows the (real) clip as the bounding box is truncated to an int before adding it as a clip rect.
IIRC the real clip rect is a bit off. I haven't looked at PDF things for too long, but my pdf notes have:
- pdf_reference_1-7.pdf p1010 has `pp g` clip very slightly off
- ITU-T_T_88__08_2018.pdf p124 has image cut off at bottom
- clip 1 px too high or something
- 0000372.pdf p22 also has clip off
- 0000354.pdf p7: horizontal line gets clipped away
- pdf chars have one pixel left over -- maybe clipping path off by one
- 0000277.pdf p5 gradient bottom too
- "clip images" only works if "clip paths" is checked as well somehow
So maybe what this here drew was right, and the clip was (is) wrong.
Anyways, this matching the actual clip better is an improvement :)
|
Thanks! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the path rasterizer here is much slower than simply drawing four lines. This also more accurately shows the (real) clip as the bounding box is truncated to an int before adding it as a clip rect.
Fixes #23056